Patrick Georgi (pgeorgi@google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7635
-gerrit
commit 18ec790dfbdc88bcc4de47bd0c49c22705d9efd5 Author: Patrick Georgi pgeorgi@google.com Date: Wed Dec 3 11:20:51 2014 +0100
build system: fix alignment function
It seriously miscomputed alignment values, always off-by-one, and off-by-an-alignment for aligned values.
Change-Id: Ide3477d09d34d7728cb0666bb30dd9f7a3f1056d Reported-by: Dave Frodin dave.frodin@se-eng.com Signed-off-by: Patrick Georgi pgeorgi@google.com --- Makefile.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.inc b/Makefile.inc index 11989d3..880c38d 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -91,7 +91,7 @@ $(foreach supported_arch,$(ARCH_SUPPORTED), \ _toint=$(shell printf "%d" $1) _int-add2=$(shell expr $(call _toint,$1) + $(call _toint,$2)) int-add=$(if $(filter 1,$(words $1)),$(strip $1),$(call int-add,$(call _int-add2,$(word 1,$1),$(word 2,$1)) $(wordlist 3,$(words $1),$1))) -int-align=$(shell expr $(call _toint,$1) + $(call _toint,$2) - 1 - $(call _toint,$1) % $(call _toint,$2)) +int-align=$(shell A=$(call _toint,$1) B=$(call _toint,$2); expr $$A + ( ( $$B - ( $$A % $$B ) ) % $$B ) ) file-size=$(shell cat $1 | wc -c)
#######################################################################
-
Patrick Georgi