Attention is currently required from: Bora Guvendik, Dinesh Gehlot, Intel coreboot Reviewers, Kapil Porwal.
Jérémy Compostella has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/coreboot/+/86215?usp=email )
Change subject: drivers/soc/cse: Fix overflow in CSE telemetry calculation
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Why is process_cse_telemetry_data() dealing with signed for timestamps.
File src/soc/intel/common/block/cse/telemetry.c:
https://review.coreboot.org/c/coreboot/+/86215/comment/0bdf3f25_9e9be641?usp... :
PS2, Line 7: s64
shouldn't it be u64 ?
Why is process_cse_telemetry_data() dealing with signed for timestamps?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86215?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I09cc00aa595a821a57a34c38a4435e433e935ad3
Gerrit-Change-Number: 86215
Gerrit-PatchSet: 2
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Comment-Date: Wed, 29 Jan 2025 19:02:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com