Attention is currently required from: Sol Boucher.
Elyes Haouas has posted comments on this change by Sol Boucher. ( https://review.coreboot.org/c/coreboot/+/9940?usp=email )
Change subject: cbfstool: Import minimal set of files from flashmap
......................................................................
Patch Set 6:
(1 comment)
File util/cbfstool/flashmap/fmap.c:
https://review.coreboot.org/c/coreboot/+/9940/comment/9486bff2_ec911203?usp=... :
PS6, Line 669: memcpy(&buf[total_size - fmap_size(fmap) + 1],
: fmap,
: fmap_size(fmap) + 1);
it gives: ‘memcpy’ forming offset 56 is out of the bounds [0, 56] [-Warray-bounds=]
593 | memcpy(&buf[total_size - fmap_size(fmap) + 1],
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
594 | fmap,
| ~~~~~
595 | fmap_size(fmap) + 1);
| ~~~~~~~~~~~~~~~~~~~~
--
To view, visit
https://review.coreboot.org/c/coreboot/+/9940?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida33f81509abc1cf2e532435adbbf31919d96bd8
Gerrit-Change-Number: 9940
Gerrit-PatchSet: 6
Gerrit-Owner: Sol Boucher
solb@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Sol Boucher
solb@chromium.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Sol Boucher
solb@chromium.org
Gerrit-Comment-Date: Sat, 22 Feb 2025 16:04:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No