Attention is currently required from: Anson Tseng, Eric Lai, Karthik Ramasubramanian, Paul Menzel, Shou-Chieh Hsu, Subrata Banik.
Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78792?usp=email )
Change subject: mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A
......................................................................
Patch Set 2: -Code-Review
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78792/comment/c5a17dd0_0e517966 :
PS2, Line 7: mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A
Please make it a statement by adding a verb (in imperative mood). […]
Done
Patchset:
PS2:
woops if add the new SPD, please separate it
Done
PS2:
Thanks for the suggestion.
I'll abandon this CL and separate to 2 CLs.
1.spd/lp4x: Add SPD for CXDB4CBAM-ML-A in parts_spd_manifest.generated.txt
https://review.coreboot.org/c/coreboot/+/78891
2.mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A
https://review.coreboot.org/c/coreboot/+/78892
Thanks.
File spd/lp4x/set-1/parts_spd_manifest.generated.txt:
https://review.coreboot.org/c/coreboot/+/78792/comment/c67065c4_1ea513af :
PS2, Line 36: CXDB4CBAM-ML-A,spd-11.hex
+1. This should be a separate CL. Also where is the update to memory_parts. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78792?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff2ed16bcbc9b0755e60a284246aa928625fa26a
Gerrit-Change-Number: 78792
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Anson Tseng
ansontseng@google.com
Gerrit-Reviewer: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Anson Tseng
ansontseng@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 03 Nov 2023 06:37:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment