HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36877 )
Change subject: mb/{i945,ich7}: Remove redundant write on V0CTL ......................................................................
mb/{i945,ich7}: Remove redundant write on V0CTL
RCBA32(V0CTL)= 0x80000001 already done inhere i945/early_init.c
Change-Id: Ia775f4e6158a217b48629d289845537e7ccf5e79 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/apple/macbook21/early_init.c M src/mainboard/getac/p470/early_init.c M src/mainboard/ibase/mb899/early_init.c M src/mainboard/intel/d945gclf/early_init.c M src/mainboard/kontron/986lcd-m/early_init.c M src/mainboard/lenovo/t60/early_init.c M src/mainboard/lenovo/x60/early_init.c M src/mainboard/roda/rk886ex/early_init.c 8 files changed, 0 insertions(+), 22 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/36877/1
diff --git a/src/mainboard/apple/macbook21/early_init.c b/src/mainboard/apple/macbook21/early_init.c index d4654de..081e55a 100644 --- a/src/mainboard/apple/macbook21/early_init.c +++ b/src/mainboard/apple/macbook21/early_init.c @@ -20,9 +20,6 @@
void mainboard_late_rcba_config(void) { - /* V0CTL Virtual Channel 0 Resource Control */ - RCBA32(0x0014) = 0x80000001; - /* Device 1f interrupt pin register */ RCBA32(0x3100) = 0x00042210; RCBA32(0x3108) = 0x10004321; diff --git a/src/mainboard/getac/p470/early_init.c b/src/mainboard/getac/p470/early_init.c index 3684c1c..c75caad 100644 --- a/src/mainboard/getac/p470/early_init.c +++ b/src/mainboard/getac/p470/early_init.c @@ -123,9 +123,6 @@
void mainboard_late_rcba_config(void) { - /* Set up virtual channel 0 */ - //RCBA32(0x0014) = 0x80000001; - /* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00042220; /* Device 1d interrupt pin register */ diff --git a/src/mainboard/ibase/mb899/early_init.c b/src/mainboard/ibase/mb899/early_init.c index ba8d30c..0b00502 100644 --- a/src/mainboard/ibase/mb899/early_init.c +++ b/src/mainboard/ibase/mb899/early_init.c @@ -99,9 +99,6 @@
void mainboard_late_rcba_config(void) { - /* Set up virtual channel 0 */ - //RCBA32(0x0014) = 0x80000001; - /* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00042210; /* Device 1d interrupt pin register */ diff --git a/src/mainboard/intel/d945gclf/early_init.c b/src/mainboard/intel/d945gclf/early_init.c index c8dd361..b4818e4 100644 --- a/src/mainboard/intel/d945gclf/early_init.c +++ b/src/mainboard/intel/d945gclf/early_init.c @@ -23,9 +23,6 @@
void mainboard_late_rcba_config(void) { - /* Set up virtual channel 0 */ - //RCBA32(0x0014) = 0x80000001; - /* dev irq route register */ RCBA16(D31IR) = 0x0132; RCBA16(D30IR) = 0x0146; diff --git a/src/mainboard/kontron/986lcd-m/early_init.c b/src/mainboard/kontron/986lcd-m/early_init.c index 48fe493..31cb209 100644 --- a/src/mainboard/kontron/986lcd-m/early_init.c +++ b/src/mainboard/kontron/986lcd-m/early_init.c @@ -144,8 +144,6 @@
void mainboard_late_rcba_config(void) { - /* Set up virtual channel 0 */ - /* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00042210; /* Device 1d interrupt pin register */ diff --git a/src/mainboard/lenovo/t60/early_init.c b/src/mainboard/lenovo/t60/early_init.c index d3de1e4..edd167a 100644 --- a/src/mainboard/lenovo/t60/early_init.c +++ b/src/mainboard/lenovo/t60/early_init.c @@ -69,9 +69,6 @@
void mainboard_late_rcba_config(void) { - /* Set up virtual channel 0 */ - RCBA32(V0CTL) = 0x80000001; - /* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00001230; RCBA32(D29IP) = 0x40004321; diff --git a/src/mainboard/lenovo/x60/early_init.c b/src/mainboard/lenovo/x60/early_init.c index 459c246..8cf5ab4 100644 --- a/src/mainboard/lenovo/x60/early_init.c +++ b/src/mainboard/lenovo/x60/early_init.c @@ -68,9 +68,6 @@
void mainboard_late_rcba_config(void) { - /* Set up virtual channel 0 */ - RCBA32(V0CTL) = 0x80000001; - /* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00001230; RCBA32(D29IP) = 0x40004321; diff --git a/src/mainboard/roda/rk886ex/early_init.c b/src/mainboard/roda/rk886ex/early_init.c index dff1a6f..f3e24e0 100644 --- a/src/mainboard/roda/rk886ex/early_init.c +++ b/src/mainboard/roda/rk886ex/early_init.c @@ -92,8 +92,6 @@
void mainboard_late_rcba_config(void) { - /* Set up virtual channel 0 */ - /* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00042220;
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36877 )
Change subject: mb/{i945,ich7}: Remove redundant write on V0CTL ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36877 )
Change subject: mb/{i945,ich7}: Remove redundant write on V0CTL ......................................................................
Patch Set 1: Code-Review+2
Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36877 )
Change subject: mb/{i945,ich7}: Remove redundant write on V0CTL ......................................................................
mb/{i945,ich7}: Remove redundant write on V0CTL
RCBA32(V0CTL)= 0x80000001 already done inhere i945/early_init.c
Change-Id: Ia775f4e6158a217b48629d289845537e7ccf5e79 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/36877 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/apple/macbook21/early_init.c M src/mainboard/getac/p470/early_init.c M src/mainboard/ibase/mb899/early_init.c M src/mainboard/intel/d945gclf/early_init.c M src/mainboard/kontron/986lcd-m/early_init.c M src/mainboard/lenovo/t60/early_init.c M src/mainboard/lenovo/x60/early_init.c M src/mainboard/roda/rk886ex/early_init.c 8 files changed, 0 insertions(+), 22 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Arthur Heymans: Looks good to me, approved
diff --git a/src/mainboard/apple/macbook21/early_init.c b/src/mainboard/apple/macbook21/early_init.c index d4654de..081e55a 100644 --- a/src/mainboard/apple/macbook21/early_init.c +++ b/src/mainboard/apple/macbook21/early_init.c @@ -20,9 +20,6 @@
void mainboard_late_rcba_config(void) { - /* V0CTL Virtual Channel 0 Resource Control */ - RCBA32(0x0014) = 0x80000001; - /* Device 1f interrupt pin register */ RCBA32(0x3100) = 0x00042210; RCBA32(0x3108) = 0x10004321; diff --git a/src/mainboard/getac/p470/early_init.c b/src/mainboard/getac/p470/early_init.c index 3684c1c..c75caad 100644 --- a/src/mainboard/getac/p470/early_init.c +++ b/src/mainboard/getac/p470/early_init.c @@ -123,9 +123,6 @@
void mainboard_late_rcba_config(void) { - /* Set up virtual channel 0 */ - //RCBA32(0x0014) = 0x80000001; - /* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00042220; /* Device 1d interrupt pin register */ diff --git a/src/mainboard/ibase/mb899/early_init.c b/src/mainboard/ibase/mb899/early_init.c index ba8d30c..0b00502 100644 --- a/src/mainboard/ibase/mb899/early_init.c +++ b/src/mainboard/ibase/mb899/early_init.c @@ -99,9 +99,6 @@
void mainboard_late_rcba_config(void) { - /* Set up virtual channel 0 */ - //RCBA32(0x0014) = 0x80000001; - /* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00042210; /* Device 1d interrupt pin register */ diff --git a/src/mainboard/intel/d945gclf/early_init.c b/src/mainboard/intel/d945gclf/early_init.c index c8dd361..b4818e4 100644 --- a/src/mainboard/intel/d945gclf/early_init.c +++ b/src/mainboard/intel/d945gclf/early_init.c @@ -23,9 +23,6 @@
void mainboard_late_rcba_config(void) { - /* Set up virtual channel 0 */ - //RCBA32(0x0014) = 0x80000001; - /* dev irq route register */ RCBA16(D31IR) = 0x0132; RCBA16(D30IR) = 0x0146; diff --git a/src/mainboard/kontron/986lcd-m/early_init.c b/src/mainboard/kontron/986lcd-m/early_init.c index 48fe493..31cb209 100644 --- a/src/mainboard/kontron/986lcd-m/early_init.c +++ b/src/mainboard/kontron/986lcd-m/early_init.c @@ -144,8 +144,6 @@
void mainboard_late_rcba_config(void) { - /* Set up virtual channel 0 */ - /* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00042210; /* Device 1d interrupt pin register */ diff --git a/src/mainboard/lenovo/t60/early_init.c b/src/mainboard/lenovo/t60/early_init.c index d3de1e4..edd167a 100644 --- a/src/mainboard/lenovo/t60/early_init.c +++ b/src/mainboard/lenovo/t60/early_init.c @@ -69,9 +69,6 @@
void mainboard_late_rcba_config(void) { - /* Set up virtual channel 0 */ - RCBA32(V0CTL) = 0x80000001; - /* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00001230; RCBA32(D29IP) = 0x40004321; diff --git a/src/mainboard/lenovo/x60/early_init.c b/src/mainboard/lenovo/x60/early_init.c index 459c246..8cf5ab4 100644 --- a/src/mainboard/lenovo/x60/early_init.c +++ b/src/mainboard/lenovo/x60/early_init.c @@ -68,9 +68,6 @@
void mainboard_late_rcba_config(void) { - /* Set up virtual channel 0 */ - RCBA32(V0CTL) = 0x80000001; - /* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00001230; RCBA32(D29IP) = 0x40004321; diff --git a/src/mainboard/roda/rk886ex/early_init.c b/src/mainboard/roda/rk886ex/early_init.c index dff1a6f..f3e24e0 100644 --- a/src/mainboard/roda/rk886ex/early_init.c +++ b/src/mainboard/roda/rk886ex/early_init.c @@ -92,8 +92,6 @@
void mainboard_late_rcba_config(void) { - /* Set up virtual channel 0 */ - /* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00042220;
-
Arthur Heymans (Code Review) -
HAOUAS Elyes (Code Review)
-
Nico Huber (Code Review)