Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/50051 )
Change subject: acpi: Fix BERT size_t printf format error ......................................................................
acpi: Fix BERT size_t printf format error
Fix compilation on GCC 10.2.1 and address the underlying issue. The printf format specifier for a size_t type is z.
Change-Id: Ieb1db6c0c3eb4947bd3617e418bac238b70ec08f Signed-off-by: Benjamin Doron benjamin.doron00@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/50051 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/arch/x86/acpi_bert_storage.c M src/soc/intel/common/block/systemagent/memmap.c 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/arch/x86/acpi_bert_storage.c b/src/arch/x86/acpi_bert_storage.c index ec31917..f1dcf47 100644 --- a/src/arch/x86/acpi_bert_storage.c +++ b/src/arch/x86/acpi_bert_storage.c @@ -200,7 +200,7 @@ { void *cl_data = bert_allocate_storage(cl_size); if (!cl_data) { - printk(BIOS_ERR, "Error: Crashlog entry (size %lu) would exceed available region\n", + printk(BIOS_ERR, "Error: Crashlog entry (size %zu) would exceed available region\n", cl_size); return NULL; } diff --git a/src/soc/intel/common/block/systemagent/memmap.c b/src/soc/intel/common/block/systemagent/memmap.c index ce842e8..a67d050 100644 --- a/src/soc/intel/common/block/systemagent/memmap.c +++ b/src/soc/intel/common/block/systemagent/memmap.c @@ -63,7 +63,7 @@ *start = cbmem_add(CBMEM_ID_ACPI_BERT, BERT_REGION_MAX_SIZE); *size = BERT_REGION_MAX_SIZE;
- printk(BIOS_DEBUG, "Reserving BERT start %lx, size %lx\n", (uintptr_t)*start, *size); + printk(BIOS_DEBUG, "Reserving BERT start %lx, size %zx\n", (uintptr_t)*start, *size); }
void fill_postcar_frame(struct postcar_frame *pcf)