Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Julius Werner.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74203 )
Change subject: acpigen_usb.c: Fixed memory leak The fresh variable malloced, freed after use ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173186): https://review.coreboot.org/c/coreboot/+/74203/comment/1d13a765_5eb8f747 PS1, Line 16: string.c: NULL pointer dereferenced Possible unwrapped commit description (prefer a maximum 72 chars per line)
File src/lib/string.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173186): https://review.coreboot.org/c/coreboot/+/74203/comment/79bfa8d3_c20628b2 PS1, Line 182: if (str == NULL){ space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173186): https://review.coreboot.org/c/coreboot/+/74203/comment/0b51933f_1df82a80 PS1, Line 183: if (ptr == NULL){ space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173186): https://review.coreboot.org/c/coreboot/+/74203/comment/fe833d18_521e035d PS1, Line 183: if (ptr == NULL){ braces {} are not necessary for single statement blocks