Attention is currently required from: Nico Huber, Tarun Tuli, Martin L Roth, Jérémy Compostella, Angel Pons, Arthur Heymans, Kyösti Mälkki, Andrey Petrov.
Jeremy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69757 )
Change subject: [RFC] Pull libgfxinit in early romstage
......................................................................
Patch Set 3:
(1 comment)
File src/arch/x86/car.ld:
https://review.coreboot.org/c/coreboot/+/69757/comment/823e5c0b_6348692e
PS1, Line 122:
My understanding is that global **initialized** variable are not permitted in cache-as-ram. […]
I could not find a way to test a symbol value from the linker script therefor I was unable to move the zero data symbols to the .bss automatically.
However, switching to the libhwbase static mmio driver suppresses the three problematic symbols.
With a few extra changes (https://review.coreboot.org/c/libgfxinit/+/69855, https://review.coreboot.org/c/libhwbase/+/69854) which I am sure you will some concerns with I am able to get something relatively acceptable from a linker script perspective (https://review.coreboot.org/c/coreboot/+/69757/3/src/arch/x86/car.ld).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69757
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3357e746a7d94afe9d285c36ed6172c7bfd9718
Gerrit-Change-Number: 69757
Gerrit-PatchSet: 3
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Tue, 22 Nov 2022 02:47:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment