Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49319 )
Change subject: nb/intel/sandybridge: Fix handling of clock timing
......................................................................
Patch Set 1:
(1 comment)
File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/49319/comment/46a057d9_86ab1708
PS1, Line 948: if (cmd_delay < 0) {
: printk(BIOS_ERR, "C%d command delay underflow: %d\n", channel, cmd_delay);
: cmd_delay = 0;
: }
Just before I forget to mention it (the added check below reminded me): This is dead […]
Yes, I got rid of it in the follow-up
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49319
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I375adf84142079f341b060fba5e79ce4dcb002be
Gerrit-Change-Number: 49319
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 12 Jan 2021 12:27:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment