Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37762 )
Change subject: Documentation/Intel: s5 charging applet design document ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37762/4/Documentation/soc/intel/s5_... File Documentation/soc/intel/s5_charging_applet/s5_charging_applet_design_flowchart.png:
PS4: pngquant reduces this to 51K with no effort, and when reducing the number of colors to 76(! what are these for?) it's even less at 26K. Remember that everything we put into master becomes part of the permanent record.
Looking at it closely, apparently it was a jpeg at some point (see the distortions), so there ought to be more savings.
Finally, our documentation system supports Ditaa (http://ditaa.sourceforge.net/), so you could add these flow charts to the document as ASCII-art and have it rendered into something like this (while the .md file is readable in any plain old text editor). See https://review.coreboot.org/c/coreboot/+/37643/7/Documentation/technotes/201... for an example of that approach.
-
Patrick Georgi (Code Review)