Attention is currently required from: Martin Roth, Julius Werner, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49767 )
Change subject: sc7280: aop blob loading changes ......................................................................
Patch Set 22:
(26 comments)
File src/soc/qualcomm/sc7280/aop_load_reset.c:
https://review.coreboot.org/c/coreboot/+/49767/comment/aa509817_1e1aeca2 PS22, Line 11: bool aop_fw_entry; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/f67d94a7_8cbdc69b PS22, Line 11: bool aop_fw_entry; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/7ef2f2a6_5ef0d018 PS22, Line 13: struct prog aop_fw_prog = code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/14bc8345_8efdb071 PS22, Line 13: struct prog aop_fw_prog = please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/e019265e_69ccc2c3 PS22, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/0a82211c_0fba2d50 PS22, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/89010cfa_8afe772b PS22, Line 16: if (prog_locate(&aop_fw_prog)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/d619e0aa_fa62678c PS22, Line 16: if (prog_locate(&aop_fw_prog)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/58e590f1_324da335 PS22, Line 17: die("SOC image: AOP_FW not found"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/843dbcec_b2fe0da6 PS22, Line 17: die("SOC image: AOP_FW not found"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/80575870_7555e225 PS22, Line 19: aop_fw_entry = selfload(&aop_fw_prog); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/d01eedc1_29c91580 PS22, Line 19: aop_fw_entry = selfload(&aop_fw_prog); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/203c505e_aa8d0851 PS22, Line 20: if (!aop_fw_entry) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/9179c91c_cf6c9569 PS22, Line 20: if (!aop_fw_entry) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/35ef5c2e_de9ec496 PS22, Line 21: die("SOC image: AOP load failed"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/9af19c39_9f92dfae PS22, Line 21: die("SOC image: AOP load failed"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/7956a39b_e4d02542 PS22, Line 23: clock_reset_aop(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/b9ae6607_19092f07 PS22, Line 23: clock_reset_aop(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/39e5a73a_c6ea75f5 PS22, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/90fe19ca_c0572092 PS22, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/mmu.c:
https://review.coreboot.org/c/coreboot/+/49767/comment/8d518b70_2125c72f PS22, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/bc53c901_313e69f1 PS22, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/bc5dae02_f57ea14a PS22, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/fc7b08fb_b2e387ea PS22, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
https://review.coreboot.org/c/coreboot/+/49767/comment/dc61423b_2a16a699 PS22, Line 15: REGION_SIZE(dram_aop) / KiB); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/fbaec756_019e6556 PS22, Line 15: REGION_SIZE(dram_aop) / KiB); please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)