Attention is currently required from: Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52856 )
Change subject: lib/option: Move CMOS option backend to choice
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/52856/comment/d33465fc_501b1bc3
PS3, Line 125: USE_OPTION_TABLE
This should be renamed to reflect it's about CMOS, e.g. `OPTION_BACKEND_CMOS`. Can be done in a separate commit
https://review.coreboot.org/c/coreboot/+/52856/comment/b3d6d614_46bc91b7
PS3, Line 128: USE_NO_OPTION_TABLE
How about `OPTION_BACKEND_NONE` ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52856
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibcbc3db01d35b933678e5d6a203b2a9e406092fe
Gerrit-Change-Number: 52856
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Mon, 03 May 2021 14:19:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment