Change in coreboot[master]: soc/intel/common/block: Move p2sb common functions into block/p2sb
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26132 )
Change subject: soc/intel/common/block: Move p2sb common functions into block/p2sb ......................................................................
Patch Set 47:
(8 comments)
https://review.coreboot.org/#/c/26132/47/src/soc/intel/skylake/p2sb.c File src/soc/intel/skylake/p2sb.c:
https://review.coreboot.org/#/c/26132/47/src/soc/intel/skylake/p2sb.c@23 PS47, Line 23: if (count != P2SB_EP_MASK_MAX_REG) { code indent should use tabs where possible
https://review.coreboot.org/#/c/26132/47/src/soc/intel/skylake/p2sb.c@23 PS47, Line 23: if (count != P2SB_EP_MASK_MAX_REG) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26132/47/src/soc/intel/skylake/p2sb.c@24 PS47, Line 24: printk(BIOS_ERR, "Unable to program EPMASK registers\n"); code indent should use tabs where possible
https://review.coreboot.org/#/c/26132/47/src/soc/intel/skylake/p2sb.c@24 PS47, Line 24: printk(BIOS_ERR, "Unable to program EPMASK registers\n"); please, no spaces at the start of a line
https://review.coreboot.org/#/c/26132/47/src/soc/intel/skylake/p2sb.c@25 PS47, Line 25: return; code indent should use tabs where possible
https://review.coreboot.org/#/c/26132/47/src/soc/intel/skylake/p2sb.c@25 PS47, Line 25: return; please, no spaces at the start of a line
https://review.coreboot.org/#/c/26132/47/src/soc/intel/skylake/p2sb.c@26 PS47, Line 26: } code indent should use tabs where possible
https://review.coreboot.org/#/c/26132/47/src/soc/intel/skylake/p2sb.c@26 PS47, Line 26: } please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)