Change in coreboot[master]: soc/nvidia/tegra124: Prevent implicit fallthrough

[Jacob Garber (Code Review)]

Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34293 )

Change subject: soc/nvidia/tegra124: Prevent implicit fallthrough
......................................................................

soc/nvidia/tegra124: Prevent implicit fallthrough

SOR_LINK_SPEED_G5_4 is unsupported, but it is not invalid, so it
suffices to return here instead of printing the next warning message.

Change-Id: Ifca3c52635e9a39af42e6616821d1099c43c237c
Signed-off-by: Jacob Garber 
Found-by: Coverity CID 1293137
---
M src/soc/nvidia/tegra124/sor.c
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/34293/1

diff --git a/src/soc/nvidia/tegra124/sor.c b/src/soc/nvidia/tegra124/sor.c
index 9188f83..3bc50e8 100644
--- a/src/soc/nvidia/tegra124/sor.c
+++ b/src/soc/nvidia/tegra124/sor.c
@@ -844,6 +844,7 @@
    	break;
    case SOR_LINK_SPEED_G5_4:
    	printk(BIOS_WARNING, "T124 does not support 5.4G link clock.\n");
+		return;
    default:
    	printk(BIOS_WARNING, "Invalid sor link bandwidth: %d\n",
    		sor->link_cfg->link_bw);

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34293 )

Change subject: soc/nvidia/tegra124: Prevent implicit fallthrough
......................................................................

Patch Set 1: Code-Review+2

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34293 )

Change subject: soc/nvidia/tegra124: Prevent implicit fallthrough
......................................................................

soc/nvidia/tegra124: Prevent implicit fallthrough

SOR_LINK_SPEED_G5_4 is unsupported, but it is not invalid, so it
suffices to return here instead of printing the next warning message.

Change-Id: Ifca3c52635e9a39af42e6616821d1099c43c237c
Signed-off-by: Jacob Garber 
Found-by: Coverity CID 1293137
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34293
Tested-by: build bot (Jenkins) 
Reviewed-by: Julius Werner 
---
M src/soc/nvidia/tegra124/sor.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Julius Werner: Looks good to me, approved

diff --git a/src/soc/nvidia/tegra124/sor.c b/src/soc/nvidia/tegra124/sor.c
index 9188f83..3bc50e8 100644
--- a/src/soc/nvidia/tegra124/sor.c
+++ b/src/soc/nvidia/tegra124/sor.c
@@ -844,6 +844,7 @@
    	break;
    case SOR_LINK_SPEED_G5_4:
    	printk(BIOS_WARNING, "T124 does not support 5.4G link clock.\n");
+		return;
    default:
    	printk(BIOS_WARNING, "Invalid sor link bandwidth: %d\n",
    		sor->link_cfg->link_bw);