Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45912 )
Change subject: mb/google/dedede/var/waddledee: Enable GPIO based I2C Multiplexer
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45912/5/src/mainboard/google/dedede...
File src/mainboard/google/dedede/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/45912/5/src/mainboard/google/dedede...
PS5, Line 54: select DRIVERS_I2C_GPIO_MUX
It should be fine to do this in Kconfig under BOARD_GOOGLE_BASEBOARD_DEDEDE. Linker should drop the unused components for other boards.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45912
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b09e063b4377587019ade9e6e194f4aadcdd312
Gerrit-Change-Number: 45912
Gerrit-PatchSet: 5
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 05 Oct 2020 21:27:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment