Attention is currently required from: Martin Roth, Patrick Rudolph, Jonathan Zhang, Christian Walter.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50411 )
Change subject: security/intel/cbnt: Add option to generate BPM
......................................................................
Patch Set 33:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50411/comment/7fb37cfb_11be8351
PS3, Line 10: json
Ok, makes sense. Please reference the CSS documentation covering this.
Looks like CSS does not document the json file elements ATM. Maybe this can be autogenerated based on the comments around the code.
When building KM/BPM there will be an json output of the config used. The idea is to be able to reuse the same configuration later builds using a config file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50411
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38808ca56953b80bac36bd186932d6286a79bebe
Gerrit-Change-Number: 50411
Gerrit-PatchSet: 33
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Comment-Date: Mon, 29 Mar 2021 16:36:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Christian Walter
christian.walter@9elements.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment