Attention is currently required from: Lance Zhao, Paul Menzel, Duncan Laurie, Angel Pons.
jacz@semihalf.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49834 )
Change subject: acpi/acpigen.c: Remove unused functions
......................................................................
Patch Set 4:
(1 comment)
File src/acpi/acpigen.c:
https://review.coreboot.org/c/coreboot/+/49834/comment/748c401e_399fa324
PS3, Line 154: void acpigen_write_name_zero(const char *name)
: {
: acpigen_write_name(name);
: acpigen_write_zero();
: }
:
: void acpigen_write_name_one(const char *name)
: {
: acpigen_write_name(name);
: acpigen_write_one();
: }
Yes, please. IMHO, I would repurpose this change to drop them. […]
Thank you. I did as you said.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49834
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I116fd41624a8e8b536d18d747f21d3131b734dfc
Gerrit-Change-Number: 49834
Gerrit-PatchSet: 4
Gerrit-Owner: jacz@semihalf.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Duncan Laurie
dlaurie@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 26 Jan 2021 11:23:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jacz@semihalf.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment