Change in coreboot[master]: [RFC] Documentation/coding_style: Clarify line limit for text blocks - coreboot-gerrit

16 Jan 2021


      Attention is currently required from: Nico Huber.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49542 )
Change subject: [RFC] Documentation/coding_style: Clarify line limit for text blocks
......................................................................
Patch Set 1:
(1 comment)
File Documentation/coding_style.md:
https://review.coreboot.org/c/coreboot/+/49542/comment/49dd2463_dfb9ad3d 
PS1, Line 97: the overall line length should not exceed 96 chars.
...
Good question, let's leave it open for discussion? […]
Sure.
Personally, I'd prefer to only limit the text of block comments. Otherwise, some single-line comments would need to be split in two very short lines, even when they're just a single sentence.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49542
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12485453721ff01299bba2ade910793f5a032045
Gerrit-Change-Number: 49542
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Sat, 16 Jan 2021 18:34:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment