[S] Change in coreboot[master]: arch/x86/smbios: Check str for NULL in smbios_add_string() - coreboot-gerrit

3 Apr 2023


      Attention is currently required from: Paul Menzel.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73980 )
Change subject: arch/x86/smbios: Check str for NULL in smbios_add_string()
......................................................................
Patch Set 3:
(1 comment)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/73980/comment/1ead99a8_be783e78 
PS2, Line 48: 	if (str == NULL || *str == '\0')
...
It's basically just as useful as entering an empty string. […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/73980
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic228b869aea362c1f07e0808c2735ff3b285a6bd
Gerrit-Change-Number: 73980
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 03 Apr 2023 06:22:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Comment-In-Reply-To: Maximilian Brune maximilian.brune@9elements.com
Gerrit-MessageType: comment