Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48675 )
Change subject: configs/config.ocp_tiogapass: Update config ......................................................................
configs/config.ocp_tiogapass: Update config
Builtest DEBUG_RESOURCES and remove unnecessary external microcode binary inclusion.
Change-Id: Ib3851f2d0bd5ee340b7b8b5fa6e1a55eac1491d6 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M configs/config.ocp_tiogapass 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/48675/1
diff --git a/configs/config.ocp_tiogapass b/configs/config.ocp_tiogapass index ca0a5b7..e14bc24 100644 --- a/configs/config.ocp_tiogapass +++ b/configs/config.ocp_tiogapass @@ -1,5 +1,4 @@ CONFIG_VENDOR_OCP=y CONFIG_BOARD_OCP_TIOGAPASS=y -CONFIG_USE_CPU_MICROCODE_CBFS_BINS=y -CONFIG_CPU_MICROCODE_CBFS_EXTERNAL_BINS=y -CONFIG_CPU_UCODE_BINARIES="3rdparty/intel-microcode/intel-ucode/06-55-04" +CONFIG_DEFAULT_CONSOLE_LOGLEVEL_8=y +CONFIG_DEBUG_RESOURCES=y \ No newline at end of file
Hello build bot (Jenkins), Marc Jones, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48675
to look at the new patch set (#2).
Change subject: configs/config.ocp_tiogapass: Update config ......................................................................
configs/config.ocp_tiogapass: Update config
Builtest DEBUG_RESOURCES and remove unnecessary external microcode binary inclusion.
Change-Id: Ib3851f2d0bd5ee340b7b8b5fa6e1a55eac1491d6 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M configs/config.ocp_tiogapass 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/48675/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48675 )
Change subject: configs/config.ocp_tiogapass: Update config ......................................................................
Patch Set 2: Code-Review+2
Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48675 )
Change subject: configs/config.ocp_tiogapass: Update config ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48675/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48675/2//COMMIT_MSG@9 PS2, Line 9: unnecessary For clarity, it was added to the makefile in a previous patch and no longer needed here.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48675 )
Change subject: configs/config.ocp_tiogapass: Update config ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48675/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48675/2//COMMIT_MSG@9 PS2, Line 9: unnecessary
For clarity, it was added to the makefile in a previous patch and no longer needed here.
Sure, I'll make this more clear.
Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48675?usp=email )
Change subject: configs/config.ocp_tiogapass: Update config ......................................................................
Abandoned
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Marc Jones (Code Review)
-
Stefan Reinauer (Code Review)