Attention is currently required from: Arthur Heymans. Hello Arthur Heymans,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/55453
to review the following change.
Change subject: mb/{fb/fbg1701,portwell/m107}: Don't select HAVE_FSP_BIN ......................................................................
mb/{fb/fbg1701,portwell/m107}: Don't select HAVE_FSP_BIN
This selected by default if 3rdparty/fsp is used. There is no need to override this behavior in the mainboard Kconfig.
Change-Id: I01ee2e90e0eceaa3100d911b5460cf99f413b185 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/facebook/fbg1701/Kconfig M src/mainboard/portwell/m107/Kconfig 2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/55453/1
diff --git a/src/mainboard/facebook/fbg1701/Kconfig b/src/mainboard/facebook/fbg1701/Kconfig index 73294f8..dc3cdd9 100644 --- a/src/mainboard/facebook/fbg1701/Kconfig +++ b/src/mainboard/facebook/fbg1701/Kconfig @@ -15,7 +15,6 @@ select SOC_INTEL_BRASWELL select SOC_INTEL_COMMON_BLOCK_HDA_VERB select PCIEXP_L1_SUB_STATE - select HAVE_FSP_BIN select DISABLE_HPET select INTEL_GMA_HAVE_VBT select HAVE_SPD_IN_CBFS diff --git a/src/mainboard/portwell/m107/Kconfig b/src/mainboard/portwell/m107/Kconfig index 59a4bdd..c4a903d 100644 --- a/src/mainboard/portwell/m107/Kconfig +++ b/src/mainboard/portwell/m107/Kconfig @@ -9,7 +9,6 @@ select HAVE_OPTION_TABLE select SOC_INTEL_BRASWELL select PCIEXP_L1_SUB_STATE - select HAVE_FSP_BIN select DISABLE_HPET select HAVE_SPD_IN_CBFS