Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54973 )
Change subject: util/intelp2m/fsp: Fix wrong register decoding for direction and interrupt ......................................................................
util/intelp2m/fsp: Fix wrong register decoding for direction and interrupt
Using the wrong registers to build the fields led to incorrect GPIO direction and interrupt trigger values. Change the calls to fix the tables.
Change-Id: Icbeeb1fec6a863d0f86659c21924e15ae6765d47 Signed-off-by: Benjamin Doron benjamin.doron00@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/54973 Reviewed-by: Maxim Polyakov max.senia.poliak@gmail.com Reviewed-by: Michael Niewöhner foss@mniewoehner.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/intelp2m/fields/fsp/fsp.go 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Maxim Polyakov: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
diff --git a/util/intelp2m/fields/fsp/fsp.go b/util/intelp2m/fields/fsp/fsp.go index 360333a..be3cde9 100644 --- a/util/intelp2m/fields/fsp/fsp.go +++ b/util/intelp2m/fields/fsp/fsp.go @@ -74,7 +74,7 @@ 1 << 4 | 0: "GpioDirInInvOut", 1 << 4 | 1: "GpioDirInInv", }, - value : dw0.GetRxInvert() << 4 | dw0.GetRXLevelEdgeConfiguration(), + value : dw0.GetRxInvert() << 4 | dw0.GetGPIORxTxDisableStatus(), },
&field { @@ -116,7 +116,7 @@ 2: "GpioIntLvlEdgDis", 3: "GpioIntBothEdge", }, - value : dw0.GetResetConfig(), + value : dw0.GetRXLevelEdgeConfiguration(), },
&field {