Change in coreboot[master]: drivers/ipmi: implement "POST complete" notification functionality
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48096 )
Change subject: drivers/ipmi: implement "POST complete" notification functionality ......................................................................
Patch Set 41: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/48096/41/src/drivers/ipmi/chip.h File src/drivers/ipmi/chip.h:
https://review.coreboot.org/c/coreboot/+/48096/41/src/drivers/ipmi/chip.h@26 PS41, Line 26: u16 same thing as previous CL, I think `gpio_t` is more clear
https://review.coreboot.org/c/coreboot/+/48096/31/src/drivers/ipmi/ipmi_kcs_... File src/drivers/ipmi/ipmi_kcs_ops.c:
https://review.coreboot.org/c/coreboot/+/48096/31/src/drivers/ipmi/ipmi_kcs_... PS31, Line 132: bscb_post_complete.callback = bmc_set_post_complete_gpio_callback; : bscb_post_complete.arg = conf; : boot_state_sched_on_entry(&bscb_post_complete, BS_PAYLOAD_BOOT);
well, I have not found a way to set `arg` to `conf` using `BOOT_STATE_INIT_ENTRY` outside of any fun […]
you'd have to use a global variable instead for the 4th argument to BOOT_STATE_INIT_ENTRY and then set it here instead
-
Tim Wawrzynczak (Code Review)