Attention is currently required from: Johannes Hahn, Uwe Poeche, Werner Zeh.
Mario Scheithauer has posted comments on this change by Johannes Hahn. ( https://review.coreboot.org/c/coreboot/+/85606?usp=email )
The change is no longer submittable: All-Comments-Resolved and Code-Review are unsatisfied now.
Change subject: soc/intel/common/block/power_limit: Disable RAPL via MSR completely
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File src/soc/intel/common/block/power_limit/power_limit.c:
https://review.coreboot.org/c/coreboot/+/85606/comment/403e3a63_bef443b9?usp... :
PS5, Line 97: msr = rdmsr(MSR_PKG_POWER_LIMIT);
Maybe one more thing...
If you set the whole register to '0', you can skip the previous read.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85606?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8272339a991667d5ba177f4755ec40e1961d729e
Gerrit-Change-Number: 85606
Gerrit-PatchSet: 5
Gerrit-Owner: Johannes Hahn
johannes-hahn@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: siemens-bot
Gerrit-Attention: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Attention: Johannes Hahn
johannes-hahn@siemens.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Sun, 29 Dec 2024 16:54:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes