Attention is currently required from: Angel Pons, Patrick Rudolph, Elyes Haouas.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61517 )
Change subject: aopen/dxplplusu: Support SMM_ASEG and SMM_TSEG ......................................................................
Patch Set 8:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61517/comment/09655ff9_e8aedb5c PS7, Line 13:
'occuring' may be misspelled - perhaps 'occurring'? […]
Done
File src/northbridge/intel/e7505/Kconfig:
https://review.coreboot.org/c/coreboot/+/61517/comment/484839cf_75e6ae4c PS7, Line 13: #select SMM_ASEG
Should this be selectable?
Removed.
File src/northbridge/intel/e7505/memmap.c:
https://review.coreboot.org/c/coreboot/+/61517/comment/e4ea927d_a7d97a49 PS7, Line 42: return 512 *KiB;
need consistent spacing around '*' (ctx:WxV) […]
Done
https://review.coreboot.org/c/coreboot/+/61517/comment/34a169f8_c94c7f0f PS7, Line 54: tolm -= northbridge_get_tseg_size();
Since most other places also use TSEG size, would it be a good idea to have a function that returns […]
If you think of a nicer way, there is about 10 variations under nb/intel to convert.
-
Kyösti Mälkki (Code Review)