Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78209?usp=email )
Change subject: mb/google/geralt: Update voltage mapping tables for RAM ID and LCMD ID ......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/geralt/boardid.c:
https://review.coreboot.org/c/coreboot/+/78209/comment/0e453876_48d45049 : PS2, Line 12: 12 8
We should probably change the code to
``` static const unsigned int ram_voltages[] = { .... };
_Static_assert(ARRAY_SIZE(ram_voltages) == ADC_LEVELS, "Wrong array size of ram_voltages"); ```
to avoid the same mistake in the future.
https://review.coreboot.org/c/coreboot/+/78209/comment/d1766083_d297c081 : PS2, Line 25: One space can be removed. Same for `panel_voltages`.