HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43943 )
Change subject: src/soc/sifive: Add missing <{stddef,stdint}.h> ......................................................................
src/soc/sifive: Add missing <{stddef,stdint}.h>
Change-Id: I07110ad3b8d8376fc23eea0a512ba469f8f7213e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/sifive/fu540/clock.c M src/soc/sifive/fu540/sdram.c M src/soc/sifive/fu540/spi.c 3 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/43943/1
diff --git a/src/soc/sifive/fu540/clock.c b/src/soc/sifive/fu540/clock.c index 9b21532..90b380e 100644 --- a/src/soc/sifive/fu540/clock.c +++ b/src/soc/sifive/fu540/clock.c @@ -4,6 +4,7 @@ #include <console/console.h> #include <soc/clock.h> #include <soc/addressmap.h> +#include <stddef.h> #include <stdint.h>
// 33.33 Mhz after reset diff --git a/src/soc/sifive/fu540/sdram.c b/src/soc/sifive/fu540/sdram.c index 3f2f498..dd370b2 100644 --- a/src/soc/sifive/fu540/sdram.c +++ b/src/soc/sifive/fu540/sdram.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
+#include <stddef.h> +#include <stdint.h> #include <soc/sdram.h> #include <soc/addressmap.h>
diff --git a/src/soc/sifive/fu540/spi.c b/src/soc/sifive/fu540/spi.c index d877452..50a9849 100644 --- a/src/soc/sifive/fu540/spi.c +++ b/src/soc/sifive/fu540/spi.c @@ -1,6 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <device/mmio.h> +#include <stddef.h> +#include <stdint.h> #include <soc/spi.h> #include <soc/clock.h> #include <soc/addressmap.h>
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43943 )
Change subject: src/soc/sifive: Add missing <{stddef,stdint}.h> ......................................................................
Patch Set 1:
(5 comments)
I've added comments to make the review easy
https://review.coreboot.org/c/coreboot/+/43943/1/src/soc/sifive/fu540/clock.... File src/soc/sifive/fu540/clock.c:
https://review.coreboot.org/c/coreboot/+/43943/1/src/soc/sifive/fu540/clock.... PS1, Line 196: size_t stddef
https://review.coreboot.org/c/coreboot/+/43943/1/src/soc/sifive/fu540/sdram.... File src/soc/sifive/fu540/sdram.c:
https://review.coreboot.org/c/coreboot/+/43943/1/src/soc/sifive/fu540/sdram.... PS1, Line 39: uint64_t stdint
https://review.coreboot.org/c/coreboot/+/43943/1/src/soc/sifive/fu540/sdram.... PS1, Line 48: size_t stddef
https://review.coreboot.org/c/coreboot/+/43943/1/src/soc/sifive/fu540/spi.c File src/soc/sifive/fu540/spi.c:
https://review.coreboot.org/c/coreboot/+/43943/1/src/soc/sifive/fu540/spi.c@... PS1, Line 22: uint8_t stdint
https://review.coreboot.org/c/coreboot/+/43943/1/src/soc/sifive/fu540/spi.c@... PS1, Line 72: size_t stddef
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43943 )
Change subject: src/soc/sifive: Add missing <{stddef,stdint}.h> ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review)