Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/28393 )
Change subject: mb/lenovo: Dual Graphics for xx20/xx30 ThinkPads ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/28393/2/src/mainboard/lenovo/t430s/romstage.... File src/mainboard/lenovo/t430s/romstage.c:
https://review.coreboot.org/#/c/28393/2/src/mainboard/lenovo/t430s/romstage.... PS2, Line 72: enum hybrid_graphics_req mode = HYBRID_GRAPHICS_INTEGRATED;
why not using the hybrid graphics driver ? it looks like the code is the same. Just use: […]
Well, here https://review.coreboot.org/c/coreboot/+/28380/2/src/mainboard/lenovo/t430s/... you pointed me at "DRIVERS_LENOVO_HYBRID_GRAPHICS" in Kconfig and said that there's no hybrid graphics in this model, I thought that means "don't use it".
-
Evgeny Zinoviev (Code Review)