Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39714 )
Change subject: mb/intel/cedarisland_crb: Add Cedar Island CRB board ......................................................................
Patch Set 5: Code-Review+1
(7 comments)
https://review.coreboot.org/c/coreboot/+/39714/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39714/5//COMMIT_MSG@7 PS5, Line 7: CRB board Customer Reference Board board 😄
https://review.coreboot.org/c/coreboot/+/39714/5/src/mainboard/intel/cedaris... File src/mainboard/intel/cedarisland_crb/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/39714/5/src/mainboard/intel/cedaris... PS5, Line 30: /* The This comment should start like this:
/* * The ...
https://review.coreboot.org/c/coreboot/+/39714/5/src/mainboard/intel/cedaris... File src/mainboard/intel/cedarisland_crb/acpi_tables.c:
PS5: If you plan on adding more things, it's not a problem. However, if the file is unused, I think you can remove it.
https://review.coreboot.org/c/coreboot/+/39714/5/src/mainboard/intel/cedaris... File src/mainboard/intel/cedarisland_crb/bootblock.c:
https://review.coreboot.org/c/coreboot/+/39714/5/src/mainboard/intel/cedaris... PS5, Line 16: com COM
https://review.coreboot.org/c/coreboot/+/39714/5/src/mainboard/intel/cedaris... PS5, Line 20: com1 COM1
https://review.coreboot.org/c/coreboot/+/39714/5/src/mainboard/intel/cedaris... File src/mainboard/intel/cedarisland_crb/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39714/5/src/mainboard/intel/cedaris... PS5, Line 6: device pci 00.0 on end # Host bridge Please indent this
https://review.coreboot.org/c/coreboot/+/39714/5/src/mainboard/intel/cedaris... PS5, Line 53: end This `end` is surrounded by two newlines, while the others aren't
-
Angel Pons (Code Review)