Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43210 )
Change subject: device/pci_device.c: Drop dead code ......................................................................
device/pci_device.c: Drop dead code
This code is not even being build-tested. Drop it before it grows moss.
Change-Id: Id3f9dd264e82f93a438422e388d70e3f88ae0df9 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/device/pci_device.c 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/43210/1
diff --git a/src/device/pci_device.c b/src/device/pci_device.c index 032e15c..3623c3b 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -1631,11 +1631,6 @@
pci_write_config8(dev, PCI_INTERRUPT_LINE, pIntAtoD[line - 1]);
-#ifdef PARANOID_IRQ_ASSIGNMENTS - irq = pci_read_config8(pdev, PCI_INTERRUPT_LINE); - printk(BIOS_DEBUG, " Readback = %d\n", irq); -#endif - #if CONFIG(PC80_SYSTEM) /* Change to level triggered. */ i8259_configure_irq_trigger(pIntAtoD[line - 1],
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43210 )
Change subject: device/pci_device.c: Drop dead code ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43210 )
Change subject: device/pci_device.c: Drop dead code ......................................................................
device/pci_device.c: Drop dead code
This code is not even being build-tested. Drop it before it grows moss.
Change-Id: Id3f9dd264e82f93a438422e388d70e3f88ae0df9 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43210 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner --- M src/device/pci_device.c 1 file changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/device/pci_device.c b/src/device/pci_device.c index 032e15c..3623c3b 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -1631,11 +1631,6 @@
pci_write_config8(dev, PCI_INTERRUPT_LINE, pIntAtoD[line - 1]);
-#ifdef PARANOID_IRQ_ASSIGNMENTS - irq = pci_read_config8(pdev, PCI_INTERRUPT_LINE); - printk(BIOS_DEBUG, " Readback = %d\n", irq); -#endif - #if CONFIG(PC80_SYSTEM) /* Change to level triggered. */ i8259_configure_irq_trigger(pIntAtoD[line - 1],