Angel Pons submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
device/pci_device.c: Drop dead code

This code is not even being build-tested. Drop it before it grows moss.

Change-Id: Id3f9dd264e82f93a438422e388d70e3f88ae0df9
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43210
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Michael Niewöhner
---
M src/device/pci_device.c
1 file changed, 0 insertions(+), 5 deletions(-)

diff --git a/src/device/pci_device.c b/src/device/pci_device.c
index 032e15c..3623c3b 100644
--- a/src/device/pci_device.c
+++ b/src/device/pci_device.c
@@ -1631,11 +1631,6 @@

pci_write_config8(dev, PCI_INTERRUPT_LINE, pIntAtoD[line - 1]);

-#ifdef PARANOID_IRQ_ASSIGNMENTS
- irq = pci_read_config8(pdev, PCI_INTERRUPT_LINE);
- printk(BIOS_DEBUG, " Readback = %d\n", irq);
-#endif
-
#if CONFIG(PC80_SYSTEM)
/* Change to level triggered. */
i8259_configure_irq_trigger(pIntAtoD[line - 1],

To view, visit change 43210. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3f9dd264e82f93a438422e388d70e3f88ae0df9
Gerrit-Change-Number: 43210
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged