Change in coreboot[master]: nb/intel/i945/raminit.c: Replace `DIMM0` - coreboot-gerrit

4 Apr 2021


      Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52073 )
Change subject: nb/intel/i945/raminit.c: Replace `DIMM0`
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/c/coreboot/+/52073/comment/5c9b86d5_ace5baff 
PS1, Line 48: 0x50
...
There's no rule saying that SPD index 0x50 is DIMM0. […]
ok, thanks
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52073
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3bd8ccdf79d1e3fdf97cda049f81271bb017ef7
Gerrit-Change-Number: 52073
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Sun, 04 Apr 2021 14:08:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Gerrit-MessageType: comment