David Imhoff (dimhoff_devel@xs4all.nl) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10100
-gerrit
commit f48b5927221b7a0f13a04699679ee67fd25e6f06 Author: David Imhoff dimhoff_devel@xs4all.nl Date: Tue May 5 12:45:54 2015 +0200
fsp platforms: Notify FSP after PCI device init
Notify FSP of the EnumInitPhaseAfterPciEnumeration stage after PCI device initialization. As described in fsp-architecture-spec.pdf, April 2014, Par 6.8.3. This fixes shutdown issues on Minnowboard Max.
TEST=Built and booted on Minnowboard Max. Verified power LED off after Linux power off.
Change-Id: Ia6508c07aa53ba436bb5899a48ecd64a117524e5 Signed-off-by: David Imhoff dimhoff_devel@xs4all.nl --- src/drivers/intel/fsp1_0/fsp_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/drivers/intel/fsp1_0/fsp_util.c b/src/drivers/intel/fsp1_0/fsp_util.c index 3147b67..93e25a9 100644 --- a/src/drivers/intel/fsp1_0/fsp_util.c +++ b/src/drivers/intel/fsp1_0/fsp_util.c @@ -343,7 +343,7 @@ static void fsp_finalize(void *unused) }
/* Set up for the ramstage FSP calls */ -BOOT_STATE_INIT_ENTRY(BS_DEV_ENUMERATE, BS_ON_EXIT, fsp_after_pci_enum, NULL); +BOOT_STATE_INIT_ENTRY(BS_POST_DEVICE, BS_ON_EXIT, fsp_after_pci_enum, NULL); BOOT_STATE_INIT_ENTRY(BS_PAYLOAD_BOOT, BS_ON_ENTRY, fsp_finalize, NULL);
/* Update the MRC/fast boot cache as part of the late table writing stage */