[XS] Change in coreboot[main]: nb/amd/pi/00730F01/state_machine: re-enable LPC decodes - coreboot-gerrit

8 Jan 2024


      Attention is currently required from: Felix Held, Martin L Roth, Matt DeVillier.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79852?usp=email )
Change subject: nb/amd/pi/00730F01/state_machine: re-enable LPC decodes
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: 
Another way to do it is to set FCH_RESET_DATA_BLOCK->LegacyFree to 0 in
board_FCH_InitReset(), if HAS_AGESA_FCH_OEM_CALLOUT is enabled. That way
one can debug AGESA state machine without a gap in the output.
I'm not strongly opposed to this approach, just leaving this comment as
another option.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/79852?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91ef4423bd7bf6c1d7a175336f0f89479f2cde02
Gerrit-Change-Number: 79852
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Krystian Hebel krystian.hebel@3mdeb.com
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 08 Jan 2024 21:30:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment