Attention is currently required from: Tarun Tuli, David Wu, Ren Kuo, Tyler Wang, Nick Vaccaro.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69693 )
Change subject: mb/google/brya/var/craask: Modify GPIOs for craaskneto/craaskino ......................................................................
Patch Set 6:
(4 comments)
File src/mainboard/google/brya/variants/craask/fw_config.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164218): https://review.coreboot.org/c/coreboot/+/69693/comment/374fd097_d6d3ebad PS6, Line 67: /* craask: board id = 0x00 ~ 0x1f */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164218): https://review.coreboot.org/c/coreboot/+/69693/comment/639d2bdc_8c1f9403 PS6, Line 95: /* craaskneto/craaskino: board id >= 0x20 */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164218): https://review.coreboot.org/c/coreboot/+/69693/comment/c4fb16bc_beb9c7a6 PS6, Line 118: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164218): https://review.coreboot.org/c/coreboot/+/69693/comment/cc54ee8e_df07ee90 PS6, Line 118: } please, no spaces at the start of a line