Alec Wang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45732 )
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
mb/google/dedede: update devicetree for Boten
Add trackpad, touchscreen, and usb port to devicetree
BUG=b:160664447 BRANCH=NONE TEST=build bios and verify theirs function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I057f7d15d20d1a78acd733cc5463357e9c87afb2 --- M src/mainboard/google/dedede/variants/boten/overridetree.cb 1 file changed, 75 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/45732/1
diff --git a/src/mainboard/google/dedede/variants/boten/overridetree.cb b/src/mainboard/google/dedede/variants/boten/overridetree.cb index 61dff93..33911d3 100644 --- a/src/mainboard/google/dedede/variants/boten/overridetree.cb +++ b/src/mainboard/google/dedede/variants/boten/overridetree.cb @@ -35,7 +35,82 @@ .speed = I2C_SPEED_FAST, }, }" + + # USB Port Configuration + register "usb2_ports[4]" = "USB2_PORT_EMPTY" # Not Used + register "usb2_ports[5]" = "USB2_PORT_MID(OC_SKIP)" # UF Camera + register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)" # WF Camera + device domain 0 on + device pci 14.0 on + chip drivers/usb/acpi + register "desc" = ""Root Hub"" + register "type" = "UPC_TYPE_HUB" + device usb 0.0 on + chip drivers/usb/acpi + register "desc" = ""Right Type-A Port"" + register "type" = "UPC_TYPE_A" + register "group" = "ACPI_PLD_GROUP(2, 1)" + device usb 2.1 on end + end + chip drivers/usb/acpi + register "desc" = ""UFCamera"" + register "type" = "UPC_TYPE_INTERNAL" + device usb 2.5 on end + end + chip drivers/usb/acpi + register "desc" = ""WFCamera"" + register "type" = "UPC_TYPE_INTERNAL" + device usb 2.6 on end + end + chip drivers/usb/acpi + register "desc" = ""Right Type-A Port"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(2, 1)" + device usb 3.1 on end + end + end + end + end # USB xHCI + device pci 15.0 on + chip drivers/i2c/generic + register "hid" = ""ELAN0000"" + register "desc" = ""ELAN Touchpad"" + register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3)" + register "wake" = "GPE0_DW0_03" + register "probed" = "1" + device i2c 15 on end + end + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3)" + register "generic.wake" = "GPE0_DW0_03" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 0x2c on end + end + end # I2C 0 + device pci 15.1 off end # I2C 1 + device pci 15.2 on + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4)" + register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)" + register "generic.reset_delay_ms" = "120" + register "generic.reset_off_delay_ms" = "3" + register "generic.enable_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" + register "generic.enable_delay_ms" = "12" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 0x5d on end + end + end # I2C 2 + device pci 15.3 off end # I2C 3 device pci 19.0 on chip drivers/i2c/generic register "hid" = ""10EC5682""
Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45732 )
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
Set Ready For Review
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45732 )
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45732/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45732/1/src/mainboard/google/dedede... PS1, Line 50: chip drivers/usb/acpi : register "desc" = ""Right Type-A Port"" : register "type" = "UPC_TYPE_A" : register "group" = "ACPI_PLD_GROUP(2, 1)" : device usb 2.1 on end : end In the baseboard, this was on port 2.3. If we are not using that port, can we turn it off here. Same comment for the usb 3.3 port.
Also if port 3 is not used, you have to mark register "usb2_ports[3]" = "USB2_PORT_EMPTY" # Not Used
register "usb3_ports[3]" = "USB3_PORT_EMPTY" # USB3/1 Type-A Port A1
https://review.coreboot.org/c/coreboot/+/45732/1/src/mainboard/google/dedede... PS1, Line 79: GPP_B3 GPP_B3_IRQ. Same comment for Synaptics touchpad as well.
https://review.coreboot.org/c/coreboot/+/45732/1/src/mainboard/google/dedede... PS1, Line 99: GPP_D4 GPP_D4_IRQ
https://review.coreboot.org/c/coreboot/+/45732/1/src/mainboard/google/dedede... PS1, Line 104: "3" Nit: 2 ms is sufficient. Atleast that is what I see in other variants using similar Goodix TS.
Hello build bot (Jenkins), Henry Sun, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45732
to look at the new patch set (#3).
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
mb/google/dedede: update devicetree for Boten
Add trackpad, touchscreen, and usb port to devicetree
BUG=b:160664447 BRANCH=NONE TEST=build bios and verify theirs function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I057f7d15d20d1a78acd733cc5463357e9c87afb2 --- M src/mainboard/google/dedede/variants/boten/overridetree.cb 1 file changed, 75 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/45732/3
Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45732 )
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45732/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45732/1/src/mainboard/google/dedede... PS1, Line 50: chip drivers/usb/acpi : register "desc" = ""Right Type-A Port"" : register "type" = "UPC_TYPE_A" : register "group" = "ACPI_PLD_GROUP(2, 1)" : device usb 2.1 on end : end
In the baseboard, this was on port 2.3. If we are not using that port, can we turn it off here. […]
Done. It used for LTE.
https://review.coreboot.org/c/coreboot/+/45732/1/src/mainboard/google/dedede... PS1, Line 79: GPP_B3
GPP_B3_IRQ. Same comment for Synaptics touchpad as well.
Done
https://review.coreboot.org/c/coreboot/+/45732/1/src/mainboard/google/dedede... PS1, Line 99: GPP_D4
GPP_D4_IRQ
Done
https://review.coreboot.org/c/coreboot/+/45732/1/src/mainboard/google/dedede... PS1, Line 104: "3"
Nit: 2 ms is sufficient. Atleast that is what I see in other variants using similar Goodix TS.
Done
Hello build bot (Jenkins), Henry Sun, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45732
to look at the new patch set (#4).
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
mb/google/dedede: update devicetree for Boten
Add trackpad, touchscreen, and usb port to devicetree
BUG=b:160664447 BRANCH=NONE TEST=build bios and verify theirs function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I057f7d15d20d1a78acd733cc5463357e9c87afb2 --- M src/mainboard/google/dedede/variants/boten/overridetree.cb 1 file changed, 75 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/45732/4
Hello build bot (Jenkins), Henry Sun, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45732
to look at the new patch set (#5).
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
mb/google/dedede: update devicetree for Boten
Add trackpad, touchscreen, and usb port to devicetree
BUG=b:160664447 BRANCH=NONE TEST=build bios and verify theirs function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I057f7d15d20d1a78acd733cc5463357e9c87afb2 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 3 files changed, 92 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/45732/5
Hello build bot (Jenkins), Henry Sun, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45732
to look at the new patch set (#6).
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
mb/google/dedede: update devicetree for Boten
Add trackpad, touchscreen, stylus, and usb port to devicetree
BUG=b:160664447 BRANCH=NONE TEST=build bios and verify theirs function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I057f7d15d20d1a78acd733cc5463357e9c87afb2 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 3 files changed, 92 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/45732/6
Hello build bot (Jenkins), Henry Sun, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45732
to look at the new patch set (#7).
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
mb/google/dedede: update devicetree for Boten
Add trackpad, touchscreen, and usb port to devicetree
BUG=b:160664447 BRANCH=NONE TEST=build bios and verify theirs function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I057f7d15d20d1a78acd733cc5463357e9c87afb2 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 3 files changed, 91 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/45732/7
Ben Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45732 )
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45732/7/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45732/7/src/mainboard/google/dedede... PS7, Line 31: .i2c[3] = { : .speed = I2C_SPEED_FAST, : }, You can remove it, if I2C3 is unused.
Hello build bot (Jenkins), Henry Sun, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45732
to look at the new patch set (#8).
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
mb/google/dedede: update devicetree for Boten
Add trackpad, touchscreen, and usb port to devicetree
BUG=b:160664447 BRANCH=NONE TEST=build bios and verify theirs function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I057f7d15d20d1a78acd733cc5463357e9c87afb2 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 3 files changed, 101 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/45732/8
Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45732 )
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45732/7/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45732/7/src/mainboard/google/dedede... PS7, Line 31: .i2c[3] = { : .speed = I2C_SPEED_FAST, : },
You can remove it, if I2C3 is unused.
Done
Hello build bot (Jenkins), Henry Sun, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45732
to look at the new patch set (#9).
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
mb/google/dedede: update devicetree for Boten
Add trackpad, touchscreen, and usb port to devicetree
BUG=b:160664447 BRANCH=NONE TEST=build bios and verify theirs function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I057f7d15d20d1a78acd733cc5463357e9c87afb2 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 3 files changed, 113 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/45732/9
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45732 )
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45732/9/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/45732/9/src/mainboard/google/dedede... PS9, Line 5: select DRIVERS_GENERIC_GPIO_KEYS This specific change need to be part of a separate CL. No PEN devices are added in the device tree.
https://review.coreboot.org/c/coreboot/+/45732/9/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/gpio.c:
https://review.coreboot.org/c/coreboot/+/45732/9/src/mainboard/google/dedede... PS9, Line 11: PAD_CFG_GPI_SCI(GPP_C12, NONE, DEEP, EDGE_SINGLE, NONE), This specific change need to be part of a separate CL. No PEN devices are added in the device tree.
Hello build bot (Jenkins), Henry Sun, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45732
to look at the new patch set (#10).
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
mb/google/dedede: update devicetree for Boten
Add trackpad, touchscreen, stylus, and usb port to devicetree
BUG=b:160664447 BRANCH=NONE TEST=build bios and verify theirs function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I057f7d15d20d1a78acd733cc5463357e9c87afb2 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 3 files changed, 113 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/45732/10
Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45732 )
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45732/9/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/45732/9/src/mainboard/google/dedede... PS9, Line 5: select DRIVERS_GENERIC_GPIO_KEYS
This specific change need to be part of a separate CL. No PEN devices are added in the device tree.
I have modified description and added PEN to devicetree in patchset5.
https://review.coreboot.org/c/coreboot/+/45732/9/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/gpio.c:
https://review.coreboot.org/c/coreboot/+/45732/9/src/mainboard/google/dedede... PS9, Line 11: PAD_CFG_GPI_SCI(GPP_C12, NONE, DEEP, EDGE_SINGLE, NONE),
This specific change need to be part of a separate CL. No PEN devices are added in the device tree.
I have modified description and added PEN to devicetree in patchset5.
Hello build bot (Jenkins), Henry Sun, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45732
to look at the new patch set (#11).
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
mb/google/dedede: update devicetree for Boten
Add trackpad, touchscreen, and usb port to devicetree
BUG=b:160664447 BRANCH=NONE TEST=build bios and verify theirs function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I057f7d15d20d1a78acd733cc5463357e9c87afb2 --- M src/mainboard/google/dedede/variants/boten/overridetree.cb 1 file changed, 95 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/45732/11
Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45732 )
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45732/9/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/45732/9/src/mainboard/google/dedede... PS9, Line 5: select DRIVERS_GENERIC_GPIO_KEYS
I have modified description and added PEN to devicetree in patchset5.
PEN removed and I will create new CL for it.
https://review.coreboot.org/c/coreboot/+/45732/9/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/gpio.c:
https://review.coreboot.org/c/coreboot/+/45732/9/src/mainboard/google/dedede... PS9, Line 11: PAD_CFG_GPI_SCI(GPP_C12, NONE, DEEP, EDGE_SINGLE, NONE),
I have modified description and added PEN to devicetree in patchset5.
PEN removed and I will create new CL for it.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45732 )
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45732/11/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45732/11/src/mainboard/google/deded... PS11, Line 64: register "group" = "ACPI_PLD_GROUP(2, 2)" PLD does not need to be defined for Internal USB ports. Same comment for USB3.3 port.
Hello build bot (Jenkins), Henry Sun, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45732
to look at the new patch set (#12).
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
mb/google/dedede: update devicetree for Boten
Add trackpad, touchscreen, and usb port to devicetree
BUG=b:160664447 BRANCH=NONE TEST=build bios and verify theirs function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I057f7d15d20d1a78acd733cc5463357e9c87afb2 --- M src/mainboard/google/dedede/variants/boten/overridetree.cb 1 file changed, 83 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/45732/12
Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45732 )
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
Patch Set 12: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45732/11/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45732/11/src/mainboard/google/deded... PS11, Line 64: register "group" = "ACPI_PLD_GROUP(2, 2)"
PLD does not need to be defined for Internal USB ports. Same comment for USB3.3 port.
Done. I have removed it. Thanks.
Alec Wang has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/45732 )
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
Removed Code-Review+1 by Alec Wang alec.wang@lcfc.corp-partner.google.com
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45732 )
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45732/11/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45732/11/src/mainboard/google/deded... PS11, Line 64: register "group" = "ACPI_PLD_GROUP(2, 2)"
Done. I have removed it. Thanks.
Sorry I meant to remove only the line: register "group" = "ACPI_PLD_GROUP(2, 2)"
That configuration is meant for user-visible USB ports. The rest of the configuration is required: chip drivers/usb/acpi register "desc" = ""LTE"" register "type" = "UPC_TYPE_INTERNAL" device usb 3.3 on end end
Hello build bot (Jenkins), Henry Sun, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45732
to look at the new patch set (#13).
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
mb/google/dedede: update devicetree for Boten
Add trackpad, touchscreen, and usb port to devicetree
BUG=b:160664447 BRANCH=NONE TEST=build bios and verify theirs function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I057f7d15d20d1a78acd733cc5463357e9c87afb2 --- M src/mainboard/google/dedede/variants/boten/overridetree.cb 1 file changed, 93 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/45732/13
Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45732 )
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45732/11/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45732/11/src/mainboard/google/deded... PS11, Line 64: register "group" = "ACPI_PLD_GROUP(2, 2)"
Sorry I meant to remove only the line: […]
Sorry, I misunderstand. Done.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45732 )
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
Patch Set 13: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45732 )
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
mb/google/dedede: update devicetree for Boten
Add trackpad, touchscreen, and usb port to devicetree
BUG=b:160664447 BRANCH=NONE TEST=build bios and verify theirs function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I057f7d15d20d1a78acd733cc5463357e9c87afb2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45732 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/boten/overridetree.cb 1 file changed, 93 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/boten/overridetree.cb b/src/mainboard/google/dedede/variants/boten/overridetree.cb index 61dff93..2ba6d9d 100644 --- a/src/mainboard/google/dedede/variants/boten/overridetree.cb +++ b/src/mainboard/google/dedede/variants/boten/overridetree.cb @@ -11,7 +11,6 @@ #| I2C0 | Trackpad | #| I2C1 | Digitizer | #| I2C2 | Touchscreen | - #| I2C3 | Camera | #| I2C4 | Audio | #+-------------------+---------------------------+ register "common_soc_config" = "{ @@ -28,14 +27,104 @@ .i2c[2] = { .speed = I2C_SPEED_FAST, }, - .i2c[3] = { - .speed = I2C_SPEED_FAST, - }, .i2c[4] = { .speed = I2C_SPEED_FAST, }, }" + + # USB Port Configuration + register "usb2_ports[4]" = "USB2_PORT_EMPTY" # Not Used + register "usb2_ports[5]" = "USB2_PORT_MID(OC_SKIP)" # UF Camera + register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)" # WF Camera + + register "SerialIoI2cMode" = "{ + [PchSerialIoIndexI2C0] = PchSerialIoPci, + [PchSerialIoIndexI2C1] = PchSerialIoPci, + [PchSerialIoIndexI2C2] = PchSerialIoPci, + [PchSerialIoIndexI2C3] = PchSerialIoDisabled, + [PchSerialIoIndexI2C4] = PchSerialIoPci, + [PchSerialIoIndexI2C5] = PchSerialIoPci, + }" + device domain 0 on + device pci 14.0 on + chip drivers/usb/acpi + register "desc" = ""Root Hub"" + register "type" = "UPC_TYPE_HUB" + device usb 0.0 on + chip drivers/usb/acpi + register "desc" = ""Right Type-A Port"" + register "type" = "UPC_TYPE_A" + register "group" = "ACPI_PLD_GROUP(2, 1)" + device usb 2.1 on end + end + chip drivers/usb/acpi + register "desc" = ""LTE"" + register "type" = "UPC_TYPE_INTERNAL" + device usb 2.3 on end + end + chip drivers/usb/acpi + register "desc" = ""UFCamera"" + register "type" = "UPC_TYPE_INTERNAL" + device usb 2.5 on end + end + chip drivers/usb/acpi + register "desc" = ""WFCamera"" + register "type" = "UPC_TYPE_INTERNAL" + device usb 2.6 on end + end + chip drivers/usb/acpi + register "desc" = ""Right Type-A Port"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(2, 1)" + device usb 3.1 on end + end + chip drivers/usb/acpi + register "desc" = ""LTE"" + register "type" = "UPC_TYPE_INTERNAL" + device usb 3.3 on end + end + end + end + end # USB xHCI + device pci 15.0 on + chip drivers/i2c/generic + register "hid" = ""ELAN0000"" + register "desc" = ""ELAN Touchpad"" + register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)" + register "wake" = "GPE0_DW0_03" + register "probed" = "1" + device i2c 15 on end + end + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)" + register "generic.wake" = "GPE0_DW0_03" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 0x2c on end + end + end # I2C 0 + device pci 15.2 on + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)" + register "generic.reset_delay_ms" = "120" + register "generic.reset_off_delay_ms" = "3" + register "generic.enable_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" + register "generic.enable_delay_ms" = "12" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 0x5d on end + end + end # I2C 2 + device pci 15.3 off end # I2C 3 device pci 19.0 on chip drivers/i2c/generic register "hid" = ""10EC5682""
-
Alec Wang (Code Review) -
Ben Kao (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Patrick Georgi (Code Review)