Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31752 )
Change subject: device/pci: Place MMCONF_BASE_ADDRESS in const variable ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/31752/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31752/2//COMMIT_MSG@10 PS2, Line 10: optimisation, specially when multiple registers on In what way? Such that register is loaded once? Isn't the constant folding already done? This feels like it's just trying to fight against the compiler.
https://review.coreboot.org/#/c/31752/2/src/include/device/pci_mmio_cfg.h File src/include/device/pci_mmio_cfg.h:
https://review.coreboot.org/#/c/31752/2/src/include/device/pci_mmio_cfg.h@24 PS2, Line 24: extern const uintptr_t var_mmconf_base; What's the point of this? If it's const it can't be changed, right?