Attention is currently required from: Jason Glenesk, Furquan Shaikh, Marshall Dawson, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52041 )
Change subject: soc/amd/cezanne: Add modern standby Kconfig option
......................................................................
Patch Set 3: -Code-Review
(1 comment)
File src/soc/amd/cezanne/Kconfig:
https://review.coreboot.org/c/coreboot/+/52041/comment/10da7277_f903f6fa
PS3, Line 216: AMD_ENABLE_MODERN_STANDBY
Any particular reason to keep this as a Kconfig option rather than a chip config? Example: https://r […]
+1 sounds like a good idea.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52041
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d09bd4361f5f47360daf750efbc993010804902
Gerrit-Change-Number: 52041
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 12 Apr 2021 15:16:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment