Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Zheng Bao, Fred Reitberger, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69462 )
Change subject: soc/amd/common: Definition of EFS_OFFSET
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/include/amdblocks/psp_efs.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163255):
https://review.coreboot.org/c/coreboot/+/69462/comment/568dac64_982e64fc
PS1, Line 10: #define EFS_OFFSET ((0xffffff - (0x80000 << CONFIG_AMD_FWM_POSITION_INDEX) + 0x20000 + 1) - (FMAP_SECTION_FLASH_START & 0xffffff))
line length of 130 exceeds 96 columns
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69462
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I915c43d38c09fbb5c7835f139d0c1a4e8526aeec
Gerrit-Change-Number: 69462
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 11 Nov 2022 02:31:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment