build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59449 )
Change subject: amdfwtool: clean up psp fw parsing ......................................................................
Patch Set 1:
(11 comments)
File util/amdfwtool/data_parse.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133706): https://review.coreboot.org/c/coreboot/+/59449/comment/67b262b4_b73bd826 PS1, Line 179: if (!cb_config->have_whitelist) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133706): https://review.coreboot.org/c/coreboot/+/59449/comment/19935cc8_8862a28a PS1, Line 183: if (!cb_config->unlock_secure) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133706): https://review.coreboot.org/c/coreboot/+/59449/comment/c3608671_7a23d790 PS1, Line 187: if (!cb_config->unlock_secure) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133706): https://review.coreboot.org/c/coreboot/+/59449/comment/6ceb0b65_41763817 PS1, Line 191: if (!cb_config->use_secureos) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133706): https://review.coreboot.org/c/coreboot/+/59449/comment/2d36631d_4dfcafc5 PS1, Line 195: if (!cb_config->use_secureos) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133706): https://review.coreboot.org/c/coreboot/+/59449/comment/55db8917_0bed0c10 PS1, Line 199: if (!cb_config->use_secureos) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133706): https://review.coreboot.org/c/coreboot/+/59449/comment/cf773691_a6f2082c PS1, Line 203: if (!cb_config->load_mp2_fw) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133706): https://review.coreboot.org/c/coreboot/+/59449/comment/8817608a_2d75cf66 PS1, Line 207: if (!cb_config->load_mp2_fw) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133706): https://review.coreboot.org/c/coreboot/+/59449/comment/81800ebd_8a5a65ac PS1, Line 211: if (!cb_config->load_mp2_fw) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133706): https://review.coreboot.org/c/coreboot/+/59449/comment/b01d5387_669eff51 PS1, Line 215: if (!cb_config->s0i3) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133706): https://review.coreboot.org/c/coreboot/+/59449/comment/6937cdf7_9d586163 PS1, Line 219: if (cb_config->have_whitelist) { braces {} are not necessary for single statement blocks
-
build bot (Jenkins) (Code Review)