Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40585 )
Change subject: soc/intel/tigerlake: Add SoundWire ACPI support
......................................................................
Patch Set 4:
Patch Set 4:
Patch Set 3:
(3 comments)
This is a mix of mainboard and SOC and really doesn't belong in static ASL in the SOC directory. The code tries to support things like 2 crystal frequencies, but ends up hardcoding for one.
This really needs to be generated this so we can support it properly across boards.
I started on some code to generate this, give me a couple days and I'll upload a patch.
(can't seem to reply without clearing the WIP bit in gerrit)
Sure Duncan. W.r.t xtal frequencies, I am not sure either. Will let audio guys comment on that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40585
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie268870178f0631d6be331b32b74a00ee0037898
Gerrit-Change-Number: 40585
Gerrit-PatchSet: 4
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Naveen M
naveen.m@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-Comment-Date: Wed, 22 Apr 2020 23:05:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment