David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44901 )
Change subject: mb/google/puff: Set TCC offset to 5 for kaisa and duffy ......................................................................
mb/google/puff: Set TCC offset to 5 for kaisa and duffy
Set tcc offset to 5 degree celsius for kaisa and duffy
BUG=b:166696500 TEST=Build, and verify test result by thermal team.
Change-Id: I2bb977b98c0764f0b9cac3543074da56057717cf Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/duffy/overridetree.cb M src/mainboard/google/hatch/variants/kaisa/overridetree.cb 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/44901/1
diff --git a/src/mainboard/google/hatch/variants/duffy/overridetree.cb b/src/mainboard/google/hatch/variants/duffy/overridetree.cb index 10da161..a4fa09d 100644 --- a/src/mainboard/google/hatch/variants/duffy/overridetree.cb +++ b/src/mainboard/google/hatch/variants/duffy/overridetree.cb @@ -1,4 +1,5 @@ chip soc/intel/cannonlake + register "tcc_offset" = "5" # TCC of 95C
# Auto-switch between X4 NVMe and X2 NVMe. register "TetonGlacierMode" = "1" diff --git a/src/mainboard/google/hatch/variants/kaisa/overridetree.cb b/src/mainboard/google/hatch/variants/kaisa/overridetree.cb index dbf1851..c6aef05 100644 --- a/src/mainboard/google/hatch/variants/kaisa/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kaisa/overridetree.cb @@ -1,4 +1,5 @@ chip soc/intel/cannonlake + register "tcc_offset" = "5" # TCC of 95C
# Auto-switch between X4 NVMe and X2 NVMe. register "TetonGlacierMode" = "1"
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44901
to look at the new patch set (#2).
Change subject: mb/google/puff: Set TCC offset to 5 for kaisa and duffy ......................................................................
mb/google/puff: Set TCC offset to 5 for kaisa and duffy
Set tcc offset to 5 degree celsius for kaisa and duffy
BUG=b:166696500 TEST=Build, and verify test result by thermal team.
Change-Id: I2bb977b98c0764f0b9cac3543074da56057717cf Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/duffy/overridetree.cb M src/mainboard/google/hatch/variants/kaisa/overridetree.cb 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/44901/2
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44901 )
Change subject: mb/google/puff: Set TCC offset to 5 for kaisa and duffy ......................................................................
Patch Set 2: Code-Review+2
Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44901 )
Change subject: mb/google/puff: Set TCC offset to 5 for kaisa and duffy ......................................................................
Patch Set 2: Code-Review+2
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44901 )
Change subject: mb/google/puff: Set TCC offset to 5 for kaisa and duffy ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44901/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44901/2//COMMIT_MSG@10 PS2, Line 10: : BUG=b:1 BRANCH=puff
Hello Sam McNally, build bot (Jenkins), Edward O'Callaghan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44901
to look at the new patch set (#3).
Change subject: mb/google/puff: Set TCC offset to 5 for kaisa and duffy ......................................................................
mb/google/puff: Set TCC offset to 5 for kaisa and duffy
Set tcc offset to 5 degree celsius for kaisa and duffy
BUG=b:166696500 BRANCH=puff TEST=Build, and verify test result by thermal team.
Change-Id: I2bb977b98c0764f0b9cac3543074da56057717cf Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/duffy/overridetree.cb M src/mainboard/google/hatch/variants/kaisa/overridetree.cb 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/44901/3
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44901 )
Change subject: mb/google/puff: Set TCC offset to 5 for kaisa and duffy ......................................................................
Patch Set 3:
(1 comment)
Thanks.
https://review.coreboot.org/c/coreboot/+/44901/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44901/2//COMMIT_MSG@10 PS2, Line 10: : BUG=b:1
BRANCH=puff
Done
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44901 )
Change subject: mb/google/puff: Set TCC offset to 5 for kaisa and duffy ......................................................................
mb/google/puff: Set TCC offset to 5 for kaisa and duffy
Set tcc offset to 5 degree celsius for kaisa and duffy
BUG=b:166696500 BRANCH=puff TEST=Build, and verify test result by thermal team.
Change-Id: I2bb977b98c0764f0b9cac3543074da56057717cf Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44901 Reviewed-by: Edward O'Callaghan quasisec@chromium.org Reviewed-by: Sam McNally sammc@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/duffy/overridetree.cb M src/mainboard/google/hatch/variants/kaisa/overridetree.cb 2 files changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved Sam McNally: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/duffy/overridetree.cb b/src/mainboard/google/hatch/variants/duffy/overridetree.cb index 10da161..a4fa09d 100644 --- a/src/mainboard/google/hatch/variants/duffy/overridetree.cb +++ b/src/mainboard/google/hatch/variants/duffy/overridetree.cb @@ -1,4 +1,5 @@ chip soc/intel/cannonlake + register "tcc_offset" = "5" # TCC of 95C
# Auto-switch between X4 NVMe and X2 NVMe. register "TetonGlacierMode" = "1" diff --git a/src/mainboard/google/hatch/variants/kaisa/overridetree.cb b/src/mainboard/google/hatch/variants/kaisa/overridetree.cb index dbf1851..c6aef05 100644 --- a/src/mainboard/google/hatch/variants/kaisa/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kaisa/overridetree.cb @@ -1,4 +1,5 @@ chip soc/intel/cannonlake + register "tcc_offset" = "5" # TCC of 95C
# Auto-switch between X4 NVMe and X2 NVMe. register "TetonGlacierMode" = "1"
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44901 )
Change subject: mb/google/puff: Set TCC offset to 5 for kaisa and duffy ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 6/1/7 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/17174 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17173 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/17172 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17171 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/17170 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/17176 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17175
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
David Wu (Code Review)
-
Edward O'Callaghan (Code Review)
-
Sam McNally (Code Review)