Change in coreboot[master]: mb/ocp/monolake: Override SMBIOS UUID with the value get from BMC

[Johnny Lin (Code Review)]

Johnny Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36843 )

Change subject: mb/ocp/monolake: Override SMBIOS UUID with the value get from BMC
......................................................................

mb/ocp/monolake: Override SMBIOS UUID with the value get from BMC

Tested on OCP Mono Lake with dmidecode -t 1 and the UUID is expected.

Change-Id: I0aab4df67b7aaba8be6ddbb13984fffb2b14fe6b
Signed-off-by: Johnny Lin 
---
M src/mainboard/ocp/monolake/mainboard.c
1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/36843/1

diff --git a/src/mainboard/ocp/monolake/mainboard.c b/src/mainboard/ocp/monolake/mainboard.c
index dffd19f..3cfb3b6 100644
--- a/src/mainboard/ocp/monolake/mainboard.c
+++ b/src/mainboard/ocp/monolake/mainboard.c
@@ -95,3 +95,8 @@
    	 dimm->dimm_num);
    t->bank_locator = smbios_add_string(t->eos, locator);
 }
+/* Override SMBIOS uuid from the value get from BMC. */
+void smbios_system_set_uuid(u8 *uuid)
+{
+	ipmi_get_system_guid(BMC_KCS_BASE, uuid);
+}

[Johnny Lin (Code Review)]

Johnny Lin has removed Alexander Morgan from this change.  ( https://review.coreboot.org/c/coreboot/+/36843 )

Change subject: mb/ocp/monolake: Override SMBIOS UUID with the value get from BMC
......................................................................

Removed reviewer Alexander Morgan.

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36843 )

Change subject: mb/ocp/monolake: Override SMBIOS UUID with the value get from BMC
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/36843/1/src/mainboard/ocp/monolake/... 
File src/mainboard/ocp/monolake/mainboard.c:

https://review.coreboot.org/c/coreboot/+/36843/1/src/mainboard/ocp/monolake/... 
PS1, Line 97: }
add a newline please

[Johnny Lin (Code Review)]

Hello Andrey Petrov, Patrick Rudolph, Jingle Hsu, Morgan Jang, Patrick Rudolph, Jonathan Zhang, David Hendricks, Philipp Deppenwiese, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36843

to look at the new patch set (#4).

Change subject: mb/ocp/monolake: Override SMBIOS UUID with the value get from BMC
......................................................................

mb/ocp/monolake: Override SMBIOS UUID with the value get from BMC

Tested on OCP Mono Lake with dmidecode -t 1 and the UUID is expected.

Change-Id: I0aab4df67b7aaba8be6ddbb13984fffb2b14fe6b
Signed-off-by: Johnny Lin 
---
M src/mainboard/ocp/monolake/mainboard.c
1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/36843/4

[Johnny Lin (Code Review)]

Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36843 )

Change subject: mb/ocp/monolake: Override SMBIOS UUID with the value get from BMC
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36843/1/src/mainboard/ocp/monolake/... 
File src/mainboard/ocp/monolake/mainboard.c:

https://review.coreboot.org/c/coreboot/+/36843/1/src/mainboard/ocp/monolake/... 
PS1, Line 97: }
> add a newline please

Done

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36843 )

Change subject: mb/ocp/monolake: Override SMBIOS UUID with the value get from BMC
......................................................................

Patch Set 4: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36843 )

Change subject: mb/ocp/monolake: Override SMBIOS UUID with the value get from BMC
......................................................................

Patch Set 4:

(3 comments)

https://review.coreboot.org/c/coreboot/+/36843/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/36843/4//COMMIT_MSG@7 
PS4, Line 7: value get from BMC
> value sent by BMC

or
> value from BMC

https://review.coreboot.org/c/coreboot/+/36843/4//COMMIT_MSG@9 
PS4, Line 9: and the UUID is expected
the expected UUID is visible.

https://review.coreboot.org/c/coreboot/+/36843/4/src/mainboard/ocp/monolake/... 
File src/mainboard/ocp/monolake/mainboard.c:

https://review.coreboot.org/c/coreboot/+/36843/4/src/mainboard/ocp/monolake/... 
PS4, Line 99: value get from BMC
value from BMC

[Johnny Lin (Code Review)]

Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36843 )

Change subject: mb/ocp/monolake: Override SMBIOS UUID with the value get from BMC
......................................................................

Patch Set 4:
> Patch Set 4:
>
> (3 comments)

Hi Pual,
Because BROADWELL-DE support will be removed from master branch, I think I will abandon this change and cherry-pick it to 4.11_branch and continue. Is that ok?
Thanks.

[Johnny Lin (Code Review)]

Johnny Lin has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/36843 )

Change subject: mb/ocp/monolake: Override SMBIOS UUID with the value get from BMC
......................................................................

Abandoned

Broadwell-DE will be removed on master, cherry-pick to 4.11_branch to continue.