Change in ...coreboot[master]: mb/lenovo/t520: Fix devicetree

[Patrick Rudolph (Code Review)]

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32317

Change subject: mb/lenovo/t520: Fix devicetree
......................................................................

mb/lenovo/t520: Fix devicetree

Disable unused PCI devices.
Reduces idle power by around 0.5Watt.

Tested on Lenovo T520.

Change-Id: I6990dc5810084261b75d2a327b6a103be44fd4cc
Signed-off-by: Patrick Rudolph 
---
M src/mainboard/lenovo/t520/variants/t520/devicetree.cb
1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/32317/1

diff --git a/src/mainboard/lenovo/t520/variants/t520/devicetree.cb b/src/mainboard/lenovo/t520/variants/t520/devicetree.cb
index cf8e7ce..b3e1723 100644
--- a/src/mainboard/lenovo/t520/variants/t520/devicetree.cb
+++ b/src/mainboard/lenovo/t520/variants/t520/devicetree.cb
@@ -86,6 +86,8 @@
    		device pci 1c.6 off end # PCIe Port #7 USB 3.0 only W520
    		device pci 1c.7 off end # PCIe Port #8
    		device pci 1d.0 on end # USB2 EHCI #1
+			device pci 1e.0 off end # PCI-2-PCI bridge
+
    		device pci 1f.0 on #LPC bridge
    			chip ec/lenovo/pmh7
    				device pnp ff.1 on # dummy
@@ -165,6 +167,8 @@
    				device i2c 5f on end
    			end
    		end # SMBus
+			device pci 1f.5 off end # IDE controller
+			device pci 1f.6 off end # Thermal controller
    	end
    end
 end

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32317 )

Change subject: mb/lenovo/t520: Fix devicetree
......................................................................

Patch Set 1: Code-Review+2

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32317 )

Change subject: mb/lenovo/t520: Fix devicetree
......................................................................

Patch Set 1:

How about t530 ?

Patrick, can you comment on related CB:32101 CB:32107

[Patrick Rudolph (Code Review)]

Patrick Rudolph has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32317 )

Change subject: mb/lenovo/t520: Fix devicetree
......................................................................

mb/lenovo/t520: Fix devicetree

Disable unused PCI devices.
Reduces idle power by around 0.5Watt.

Tested on Lenovo T520.

Change-Id: I6990dc5810084261b75d2a327b6a103be44fd4cc
Signed-off-by: Patrick Rudolph 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32317
Tested-by: build bot (Jenkins) 
Reviewed-by: Arthur Heymans 
---
M src/mainboard/lenovo/t520/variants/t520/devicetree.cb
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved

diff --git a/src/mainboard/lenovo/t520/variants/t520/devicetree.cb b/src/mainboard/lenovo/t520/variants/t520/devicetree.cb
index 5f1bc60..eff2d69 100644
--- a/src/mainboard/lenovo/t520/variants/t520/devicetree.cb
+++ b/src/mainboard/lenovo/t520/variants/t520/devicetree.cb
@@ -88,6 +88,8 @@
    		device pci 1c.6 off end # PCIe Port #7 USB 3.0 only W520
    		device pci 1c.7 off end # PCIe Port #8
    		device pci 1d.0 on end # USB2 EHCI #1
+			device pci 1e.0 off end # PCI-2-PCI bridge
+
    		device pci 1f.0 on #LPC bridge
    			chip ec/lenovo/pmh7
    				device pnp ff.1 on # dummy
@@ -167,6 +169,8 @@
    				device i2c 5f on end
    			end
    		end # SMBus
+			device pci 1f.5 off end # IDE controller
+			device pci 1f.6 off end # Thermal controller
    	end
    end
 end

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32317 )

Change subject: mb/lenovo/t520: Fix devicetree
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/32317/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32317/2//COMMIT_MSG@7 
PS2, Line 7: Fix devicetree
Nit: This could have used a better commit message.
"Disable Unused PCI devices in devicetree"

Pretty much anytime you're tempted to use "fix" it's a bad commit message.  :)