Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29104 )
Change subject: sdm845: Port I2C driver ......................................................................
Patch Set 32:
(1 comment)
https://review.coreboot.org/#/c/29104/31/src/soc/qualcomm/sdm845/qcom_qup_se... File src/soc/qualcomm/sdm845/qcom_qup_se.c:
https://review.coreboot.org/#/c/29104/31/src/soc/qualcomm/sdm845/qcom_qup_se... PS31, Line 118:
Similar indentation we use in our HLOS driver and it looks good to us. […]
The problem here is just that the second line is so far over to the right compared to the first line. How did you decide to do exactly 5 tabs? That just seems arbitrary... I thought maybe this used to line up with the previous line in an earlier version but then you shortened the name of the function and forgot to realign the second line.
In general, there's no hard rule on this but the two most common versions are
- Fill to 80 and indent all continuation lines 1 tab no matter what:
int my_sample_func(int param1, int param2, int param3, int param4, int param5, int param6)
- Fill to 80 and align continuation lines to opening parenthesis
int my_sample_func(int param1, int param2, int param3, int param4, int param5, int param6)
(Note that should be 2 tabs and 3 spaces in the second example.)
-
Julius Werner (Code Review)