Attention is currently required from: Andrey Petrov, Intel coreboot Reviewers, Karthik Ramasubramanian, Ronak Kanabar.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86367?usp=email )
Change subject: lib: Centralize logo.bmp inclusion in lib/Makefile.mk
......................................................................
Patch Set 3:
(1 comment)
File src/lib/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/86367/comment/3fabc73d_71bc4ab8?usp... :
PS3, Line 427: CONFIG_FSP2_0_LOGO_FILE_NAME
Oh, I see, *all* the BMP_LOGO Kconfigs are still in the FSP folder even if most of them aren't prefixed "FSP" anymore. Yeah that's not great, if the code is in a platform-independent directory the Kconfigs should be too.
You don't need to do it now but it would be good if it got done eventually.
agree with you. will submit refactor cl later
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86367?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I16ed1cf29b839c25b6ea1c2f10faf3d99dd707c9
Gerrit-Change-Number: 86367
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 14 Feb 2025 02:56:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org