Attention is currently required from: Julius Werner, Yidi Lin, Yu-Ping Wu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78800?usp=email )
Change subject: arch/arm64/arch_timer: Fix possible overflow in multiplication
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78800/comment/37f88cbf_66e493a3 :
PS2, Line 9: The value from raw_read_cntfrq_el0() could be large enough to cause
: overflow when multiplied by 1000000. To prevent this, both 1000000 and
: tfreq can be reduced by dividing them by their GCD.
I think it's worth adding this as a comment to the code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78800?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I366667de05392913150414f0fa9058725be71c52
Gerrit-Change-Number: 78800
Gerrit-PatchSet: 2
Gerrit-Owner: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 31 Oct 2023 16:17:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment