Attention is currently required from: Martin Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52376 )
Change subject: HACK payloads: Add libpci for arm arch HACK ......................................................................
Patch Set 2:
(14 comments)
File payloads/libpayload/drivers/pci.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117225): https://review.coreboot.org/c/coreboot/+/52376/comment/fe879b16_b6e5d8f6 PS2, Line 57: #define PCIE_ATU_TYPE_IO (0x2 << 0) trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117225): https://review.coreboot.org/c/coreboot/+/52376/comment/3c9fff20_e6089d51 PS2, Line 57: #define PCIE_ATU_TYPE_IO (0x2 << 0) please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117225): https://review.coreboot.org/c/coreboot/+/52376/comment/f23f7813_3916f88a PS2, Line 84: static void dw_pcie_writel_ob_unroll(void * atu_base, "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117225): https://review.coreboot.org/c/coreboot/+/52376/comment/e22a43a5_c9f7a974 PS2, Line 224: if (current_bus == 1) Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117225): https://review.coreboot.org/c/coreboot/+/52376/comment/49a4db34_6c3c1c1d PS2, Line 231: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117225): https://review.coreboot.org/c/coreboot/+/52376/comment/807a361b_fd3cbb5b PS2, Line 248: io_size); trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117225): https://review.coreboot.org/c/coreboot/+/52376/comment/d8770a41_4ecd1a4b PS2, Line 253: u8 pci_read_config8(u32 dev, u16 reg) trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117225): https://review.coreboot.org/c/coreboot/+/52376/comment/4cd86456_954198f7 PS2, Line 254: { trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117225): https://review.coreboot.org/c/coreboot/+/52376/comment/1ef32725_a67fa761 PS2, Line 255: int val, offset = reg; trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117225): https://review.coreboot.org/c/coreboot/+/52376/comment/988c7d2e_a695a40b PS2, Line 264: qcom_read_config(NVME_PCIE_BDF(1,0,0), reg, &val, 16); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117225): https://review.coreboot.org/c/coreboot/+/52376/comment/7b8f1f77_9f97bce0 PS2, Line 264: qcom_read_config(NVME_PCIE_BDF(1,0,0), reg, &val, 16); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117225): https://review.coreboot.org/c/coreboot/+/52376/comment/270a8b1d_8c840f9b PS2, Line 268: u32 pci_read_config32(u32 dev, u16 reg) trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117225): https://review.coreboot.org/c/coreboot/+/52376/comment/7d82e574_7c30a9ad PS2, Line 343: u16 reg = 0x10+ (bar * 4); need consistent spacing around '+' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117225): https://review.coreboot.org/c/coreboot/+/52376/comment/3c3583a8_ad81b472 PS2, Line 344: val = pci_read_config32(dev, reg ); space prohibited before that close parenthesis ')'
-
build bot (Jenkins) (Code Review)