Attention is currently required from: Hung-Te Lin, Xuxin Xiong, Yang Wu.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79309?usp=email )
Change subject: mb/google/corsola: Use fw_config to differentiate audio amps
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/corsola/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79309/comment/a3ad9355_963cc5e7 :
PS1, Line 4: AUDIO_AMP
Since the option is under the AUDIO_AMP field, having the prefix `AMP` should be enough.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79309?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5f887f5e0d16dc14039fb12b636257d01339b2de
Gerrit-Change-Number: 79309
Gerrit-PatchSet: 1
Gerrit-Owner: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Wed, 29 Nov 2023 07:17:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment