Rajat Jain has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40542 )
Change subject: arch/x86/acpigen_ps2_keybd: Add JP and UK specific keymaps ......................................................................
arch/x86/acpigen_ps2_keybd: Add JP and UK specific keymaps
Add keymaps for keys that are not present in US keyboards.
Change-Id: I1ad4c483e81438456533b4c071a4a56cbee88f9c Signed-off-by: Rajat Jain rajatja@google.com --- M src/arch/x86/acpigen_ps2_keybd.c 1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/40542/1
diff --git a/src/arch/x86/acpigen_ps2_keybd.c b/src/arch/x86/acpigen_ps2_keybd.c index 1573de8..7943f9a 100644 --- a/src/arch/x86/acpigen_ps2_keybd.c +++ b/src/arch/x86/acpigen_ps2_keybd.c @@ -110,6 +110,7 @@ KEYMAP(0x0b, KEY_0), KEYMAP(0x0c, KEY_MINUS), KEYMAP(0x0d, KEY_EQUAL), + KEYMAP(0x7d, KEY_YEN), /* JP keyboards only */ KEYMAP(0x0e, KEY_BACKSPACE), /* Row-2 */ KEYMAP(0x0f, KEY_TAB), @@ -127,7 +128,7 @@ KEYMAP(0x1b, KEY_RIGHTBRACE), KEYMAP(0x2b, KEY_BACKSLASH), /* Row-3 */ - KEYMAP(0xdb, KEY_LEFTMETA), + KEYMAP(0xdb, KEY_LEFTMETA), /* Search Key */ KEYMAP(0x1e, KEY_A), KEYMAP(0x1f, KEY_S), KEYMAP(0x20, KEY_D), @@ -142,6 +143,7 @@ KEYMAP(0x1c, KEY_ENTER), /* Row-4 */ KEYMAP(0x2a, KEY_LEFTSHIFT), + KEYMAP(0x56, KEY_102ND), /* UK keyboards only */ KEYMAP(0x2c, KEY_Z), KEYMAP(0x2d, KEY_X), KEYMAP(0x2e, KEY_C), @@ -152,11 +154,14 @@ KEYMAP(0x33, KEY_COMMA), KEYMAP(0x34, KEY_DOT), KEYMAP(0x35, KEY_SLASH), + KEYMAP(0x73, KEY_RO), /* JP keyboards only */ KEYMAP(0x36, KEY_RIGHTSHIFT), /* Row-5 */ KEYMAP(0x1d, KEY_LEFTCTRL), KEYMAP(0x38, KEY_LEFTALT), + KEYMAP(0x7b, KEY_MUHENKAN), /* JP keyboards only */ KEYMAP(0x39, KEY_SPACE), + KEYMAP(0x79, KEY_HENKAN), /* JP keyboards only */ KEYMAP(0xb8, KEY_RIGHTALT), KEYMAP(0x9d, KEY_RIGHTCTRL), /* Arrow keys */
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40542 )
Change subject: arch/x86/acpigen_ps2_keybd: Add JP and UK specific keymaps ......................................................................
Patch Set 1:
Why just JP and UK?
Rajat Jain has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40542 )
Change subject: arch/x86/acpigen_ps2_keybd: Add JP and UK specific keymaps ......................................................................
Patch Set 1:
Patch Set 1:
Why just JP and UK?
There are no other keyboards - we only support US, UK, JP.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40542 )
Change subject: arch/x86/acpigen_ps2_keybd: Add JP and UK specific keymaps ......................................................................
Patch Set 1: Code-Review+2
Patch Set 1:
Patch Set 1:
Why just JP and UK?
There are no other keyboards - we only support US, UK, JP.
TIL! If those are the only extra keys required, seems fine.
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40542 )
Change subject: arch/x86/acpigen_ps2_keybd: Add JP and UK specific keymaps ......................................................................
arch/x86/acpigen_ps2_keybd: Add JP and UK specific keymaps
Add keymaps for keys that are not present in US keyboards.
Change-Id: I1ad4c483e81438456533b4c071a4a56cbee88f9c Signed-off-by: Rajat Jain rajatja@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40542 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/arch/x86/acpigen_ps2_keybd.c 1 file changed, 6 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/arch/x86/acpigen_ps2_keybd.c b/src/arch/x86/acpigen_ps2_keybd.c index 1573de8..7943f9a 100644 --- a/src/arch/x86/acpigen_ps2_keybd.c +++ b/src/arch/x86/acpigen_ps2_keybd.c @@ -110,6 +110,7 @@ KEYMAP(0x0b, KEY_0), KEYMAP(0x0c, KEY_MINUS), KEYMAP(0x0d, KEY_EQUAL), + KEYMAP(0x7d, KEY_YEN), /* JP keyboards only */ KEYMAP(0x0e, KEY_BACKSPACE), /* Row-2 */ KEYMAP(0x0f, KEY_TAB), @@ -127,7 +128,7 @@ KEYMAP(0x1b, KEY_RIGHTBRACE), KEYMAP(0x2b, KEY_BACKSLASH), /* Row-3 */ - KEYMAP(0xdb, KEY_LEFTMETA), + KEYMAP(0xdb, KEY_LEFTMETA), /* Search Key */ KEYMAP(0x1e, KEY_A), KEYMAP(0x1f, KEY_S), KEYMAP(0x20, KEY_D), @@ -142,6 +143,7 @@ KEYMAP(0x1c, KEY_ENTER), /* Row-4 */ KEYMAP(0x2a, KEY_LEFTSHIFT), + KEYMAP(0x56, KEY_102ND), /* UK keyboards only */ KEYMAP(0x2c, KEY_Z), KEYMAP(0x2d, KEY_X), KEYMAP(0x2e, KEY_C), @@ -152,11 +154,14 @@ KEYMAP(0x33, KEY_COMMA), KEYMAP(0x34, KEY_DOT), KEYMAP(0x35, KEY_SLASH), + KEYMAP(0x73, KEY_RO), /* JP keyboards only */ KEYMAP(0x36, KEY_RIGHTSHIFT), /* Row-5 */ KEYMAP(0x1d, KEY_LEFTCTRL), KEYMAP(0x38, KEY_LEFTALT), + KEYMAP(0x7b, KEY_MUHENKAN), /* JP keyboards only */ KEYMAP(0x39, KEY_SPACE), + KEYMAP(0x79, KEY_HENKAN), /* JP keyboards only */ KEYMAP(0xb8, KEY_RIGHTALT), KEYMAP(0x9d, KEY_RIGHTCTRL), /* Arrow keys */
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40542 )
Change subject: arch/x86/acpigen_ps2_keybd: Add JP and UK specific keymaps ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2539 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2538 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2537 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/2536
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Furquan Shaikh (Code Review)
-
Rajat Jain (Code Review)
-
Tim Wawrzynczak (Code Review)